Issue 51 test case

[jwfearn, 2011-11-16 03:13:22]

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
File test/org/plovr/InputFileHandlerTest.java (right):

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
test/org/plovr/InputFileHandlerTest.java:30: "foo.js");
I meant to put a comment in the code here.  The point is to create a dummy path
name using the native system separator to better simulate a local file.

[bolinfest, 2011-11-19 03:13:47]

Hi John, first, I'm sorry that it has taken me so long to get back to you here.
I'm on a Chromebook right now, which is the only reason I haven't tested the
file separator thing myself, but I'm hoping we can figure something out such
that the resulting change is not so big.

Also, if we can figure out a way for me to test both the Windows and Linux
behavior from my Linux machine so that I don't break you in the future, that
would be a double win!

http://codereview.appspot.com/5373109/diff/1/.hgignore
File .hgignore (right):

http://codereview.appspot.com/5373109/diff/1/.hgignore#newcode4
.hgignore:4: syntax: glob
could you skip a line before syntax:glob so it's clear where the sections
change?

http://codereview.appspot.com/5373109/diff/1/.hgignore#newcode5
.hgignore:5: *.iml
Could you add comments for *.iml and junit*.properties to explain if/when these
files should show up?

http://codereview.appspot.com/5373109/diff/1/build.xml
File build.xml (right):

http://codereview.appspot.com/5373109/diff/1/build.xml#newcode26
build.xml:26: <javac includeantruntime="true" />
nit: 2 space indents

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
File test/org/plovr/InputFileHandlerTest.java (right):

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
test/org/plovr/InputFileHandlerTest.java:30: "foo.js");
On 2011/11/16 03:13:22, jwfearn wrote:
> I meant to put a comment in the code here.  The point is to create a dummy
path
> name using the native system separator to better simulate a local file.

Hmm, so I think the real question is: how often is the native file path
separator actually needed? For example, when used in a URL, it will always be a
forward slash. Also, I believe that Java can tolerate things like:

new File("../../..\\bar\\foo.js");

If it turns out like this type of conversion is common, then there should be a
utility method in the application code that this test uses.

Though if I'm right about Java tolerating mixed file separators, then maybe this
does not need to be such a big change?

[jwfearn, 2011-11-21 17:47:36]

http://codereview.appspot.com/5373109/diff/1/.hgignore
File .hgignore (right):

http://codereview.appspot.com/5373109/diff/1/.hgignore#newcode4
.hgignore:4: syntax: glob
Will do.

http://codereview.appspot.com/5373109/diff/1/.hgignore#newcode5
.hgignore:5: *.iml
Will do.

http://codereview.appspot.com/5373109/diff/1/build.xml
File build.xml (right):

http://codereview.appspot.com/5373109/diff/1/build.xml#newcode26
build.xml:26: <javac includeantruntime="true" />
Oops, sorry, I thought I had used 2-space indents here.  I'll fix it.

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
File test/org/plovr/InputFileHandlerTest.java (right):

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
test/org/plovr/InputFileHandlerTest.java:30: "foo.js");
As I understand it (please correct me if I'm wrong) there are two kinds of
JavaScript input files to plovr: 1) those from the plovr-supplied Closure
Library, and 2) those that come from the local file system.  #1 files have
Unix-separated paths, #2 files have native-separated paths.  I'm assuming
'createDummyJsInput' is meant to simulate #2.

My suggestion is to a) provide an anything-including-mixed-to-Unix-separated
utility, b) always use Unix-separated internally, and c) only if needed, provide
an anything-including-mixed-to-native-separated utility.

[jwfearn, 2011-11-21 18:12:49]

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
File test/org/plovr/InputFileHandlerTest.java (right):

http://codereview.appspot.com/5373109/diff/1/test/org/plovr/InputFileHandlerT...
test/org/plovr/InputFileHandlerTest.java:30: "foo.js");
With this change alone, this test now fails on Windows.