Add GL_ANGLE_pack_reverse_row_order.

Add GL_ANGLE_pack_reverse_row_order. Performs vertical flip in readPixels and
may write direct to client ptr.

Bug=none
Test= Tested in a modified version of Chromium using canvas2D.
Committed: http://code.google.com/p/angleproject/source/detail?r=889

[dgkoch, 2011-11-22 13:44:32]

The extension is looking good.  

I've got a few comments below.  If you handle those and update the code to match
the extension it should be good.

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
File extensions/ANGLE_pack_reverse_row_order.txt (right):

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
extensions/ANGLE_pack_reverse_row_order.txt:4: ANGLE_pack_reverse_row_order
Looks like a good start.  The only thing really missing from this is
interactions with OpenGL ES.

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
extensions/ANGLE_pack_reverse_row_order.txt:11: ????
you can put me in for Contact if you don't want to be the contact.

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
extensions/ANGLE_pack_reverse_row_order.txt:72: PACK_REVERSE_ROW_ORDER_ANGLE   
0x????
use PACK_REVERSE_ROW_ORDER_ANGLE   0x93A4

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:2223: void Context::readPixels(GLint x, GLint y,
GLsizei width, GLsizei height, GLenum format, GLenum type, void* pixels)
this needs to be rebased on current source

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:2275: if (desc.MultiSampleType != D3DMULTISAMPLE_NONE)
The directToPixels and CreateOffscreenPlain code above should be after this
check, or at a minimum this early return needs a systemSurface->Release().

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:3499: mExtensionString += "GL_ANGLE_pack_flipy ";
please add new extension in sorted order

[bsalomon, 2011-11-22 19:26:37]

Thanks for the feedback! I uploaded a revised patch.

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
File extensions/ANGLE_pack_reverse_row_order.txt (right):

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
extensions/ANGLE_pack_reverse_row_order.txt:4: ANGLE_pack_reverse_row_order
On 2011/11/22 13:44:32, dgkoch wrote:
> Looks like a good start.  The only thing really missing from this is
> interactions with OpenGL ES. 
I added sections on ES and GL_EXT_texture_rg interactions.

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
extensions/ANGLE_pack_reverse_row_order.txt:11: ????
On 2011/11/22 13:44:32, dgkoch wrote:
> you can put me in for Contact if you don't want to be the contact.

Done. I don't mind being the contact, though. If you'd prefer it to be me I'm
happy to change it.

http://codereview.appspot.com/5373104/diff/2005/extensions/ANGLE_pack_reverse...
extensions/ANGLE_pack_reverse_row_order.txt:72: PACK_REVERSE_ROW_ORDER_ANGLE   
0x????
On 2011/11/22 13:44:32, dgkoch wrote:
> use PACK_REVERSE_ROW_ORDER_ANGLE   0x93A4

Done.

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:2223: void Context::readPixels(GLint x, GLint y,
GLsizei width, GLsizei height, GLenum format, GLenum type, void* pixels)
On 2011/11/22 13:44:32, dgkoch wrote:
> this needs to be rebased on current source

Done.

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:2275: if (desc.MultiSampleType != D3DMULTISAMPLE_NONE)
On 2011/11/22 13:44:32, dgkoch wrote:
> The directToPixels and CreateOffscreenPlain code above should be after this
> check, or at a minimum this early return needs a systemSurface->Release().

Done.

http://codereview.appspot.com/5373104/diff/2005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:3499: mExtensionString += "GL_ANGLE_pack_flipy ";
On 2011/11/22 13:44:32, dgkoch wrote:
> please add new extension in sorted order

Done.

[dgkoch, 2011-11-23 03:29:53]

LGTM with the one addition I pointed out.

Please update src/common/version.h with the expected SVN revision when you
commit as well.

http://codereview.appspot.com/5373104/diff/8005/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

http://codereview.appspot.com/5373104/diff/8005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:1526: case GL_PACK_ALIGNMENT:
add GL_PACK_REVERSE_ROW_ORDER_ANGLE here as well.

[bsalomon, 2011-11-23 13:34:54]

Thanks. I'll either need commit access or someone to land this for me.

http://codereview.appspot.com/5373104/diff/8005/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

http://codereview.appspot.com/5373104/diff/8005/src/libGLESv2/Context.cpp#new...
src/libGLESv2/Context.cpp:1526: case GL_PACK_ALIGNMENT:
On 2011/11/23 03:29:53, dgkoch wrote:
> add GL_PACK_REVERSE_ROW_ORDER_ANGLE here as well.

Done.

[dgkoch, 2011-11-23 13:42:37]

On 2011/11/23 13:34:54, bsalomon wrote:
> Thanks. I'll either need commit access or someone to land this for me.

I've added you as a committer.  Don't forget to bump the revision. Thanks!