Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2187)

Issue 5373100: Remove allocated size vs content size in textures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by bsalomon
Modified:
12 years, 10 months ago
Reviewers:
TomH, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -371 lines) Patch
M include/gpu/GrGLInterface.h View 1 chunk +0 lines, -10 lines 0 comments Download
M include/gpu/GrRenderTarget.h View 4 chunks +0 lines, -20 lines 0 comments Download
M include/gpu/GrTexture.h View 4 chunks +1 line, -23 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +4 lines, -12 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +0 lines, -4 lines 0 comments Download
M src/gpu/GrGLInterface.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/GrGLRenderTarget.cpp View 3 chunks +5 lines, -4 lines 0 comments Download
M src/gpu/GrGLTexture.h View 3 chunks +2 lines, -17 lines 0 comments Download
M src/gpu/GrGLTexture.cpp View 3 chunks +7 lines, -15 lines 0 comments Download
M src/gpu/GrGpu.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrGpuGL.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrGpuGL.cpp View 15 chunks +25 lines, -229 lines 0 comments Download
M src/gpu/GrGpuGLShaders.cpp View 2 chunks +6 lines, -9 lines 0 comments Download
M src/gpu/GrRenderTarget.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/ios/GrGLDefaultInterface_iOS.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/mesa/GrGLCreateMesaInterface.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/unix/GrGLCreateNativeInterface_unix.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/win/GrGLCreateNativeInterface_win.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4
bsalomon
We have three cases where we allocate a texture that is larger than is needed: ...
12 years, 10 months ago (2011-11-15 15:14:18 UTC) #1
reed1
lgtm -- assuming we're sure we don't care about any targets that needed this support. ...
12 years, 10 months ago (2011-11-15 15:20:27 UTC) #2
TomH
LGTM. Put your writeup in a doc somewhere for posterity?
12 years, 10 months ago (2011-11-15 15:42:50 UTC) #3
bsalomon
12 years, 10 months ago (2011-11-15 16:48:03 UTC) #4
On 2011/11/15 15:42:50, TomH wrote:
> LGTM.
> 
> Put your writeup in a doc somewhere for posterity?

Closed with r2687, wiki doc here:
http://code.google.com/p/skia/wiki/GrTextureViewProposal
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b