Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8034)

Issue 5373081: Bring argument processing of chord music functions in line with the rest (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by dak
Modified:
12 years, 4 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Bring argument processing of chord music functions in line with the rest The previous semantics for music functions called inside of chords were that any final music arguments were parsed as chord constituents (not taking durations and being left as NoteEvent instead of EventChord, with any postevents placed into 'articulations instead of appended to the EventChord 'elements). The ongoing unification of argument processing makes it infeasible to assign a useful meaning to the phrase "final music arguments" since music and Scheme expressions can be freely interchanged. Optional argument processing was also mostly dysfunctional due to implementing that rule without the full argument processing effort used for music functions elsewhere. This change makes chord music functions just share the normal argument processing. Any EventChord music arguments that could conceivably be from music _looking_ like a chord constituent (namely an EventChord containing a single NoteEvent without 'articulation of its own followed by optional postevents) are repackaged into the form of a chord constituent and passed in this manner to the music function; all others left alone. In order to allow the music function to facilitate return value of the music function undergoes the same treatment before getting used inside the resulting chord. Compatibility to existing usage is excellent.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -42 lines) Patch
M lily/parser.yy View 3 chunks +4 lines, -41 lines 0 comments Download
M scm/ly-syntax-constructors.scm View 2 chunks +22 lines, -1 line 0 comments Download

Messages

Total messages: 1
pkx166h
12 years, 5 months ago (2011-11-12 18:59:28 UTC) #1
Passes make, two reg test show up see

http://code.google.com/p/lilypond/issues/detail?id=2037#c2

James
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b