lgtm w/ suggestion for a comment http://codereview.appspot.com/5373064/diff/1/src/gpu/GrDrawTarget.cpp File src/gpu/GrDrawTarget.cpp (left): http://codereview.appspot.com/5373064/diff/1/src/gpu/GrDrawTarget.cpp#oldcode814 src/gpu/GrDrawTarget.cpp:814: GrPixelConfigIsUnpremultiplied(fCurrDrawState.fTextures[s]->config())) { // ...
12 years, 10 months ago
(2011-11-11 16:43:41 UTC)
#2
lgtm w/ suggestion for a comment
http://codereview.appspot.com/5373064/diff/1/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (left):
http://codereview.appspot.com/5373064/diff/1/src/gpu/GrDrawTarget.cpp#oldcode814
src/gpu/GrDrawTarget.cpp:814:
GrPixelConfigIsUnpremultiplied(fCurrDrawState.fTextures[s]->config())) {
// If the texture is unpremulitplied, we can't use the built-in bilerp, as the
operation of applying-alpha and bilerp are not symmetric (associative?), hence
we only support these with nearest_filter.
// To add support, we'd need to perform the filter (bilper) ourselves in the
shader...
http://codereview.appspot.com/5373064/diff/1/include/gpu/GrTypes.h File include/gpu/GrTypes.h (right): http://codereview.appspot.com/5373064/diff/1/include/gpu/GrTypes.h#newcode276 include/gpu/GrTypes.h:276: * has an unpremultiplied config only draws that use ...
12 years, 10 months ago
(2011-11-11 19:34:55 UTC)
#4
On 2011/11/11 19:34:55, bsalomon wrote: > On 2011/11/11 19:02:16, TomH wrote: > > Although it ...
12 years, 10 months ago
(2011-11-11 19:40:40 UTC)
#5
On 2011/11/11 19:34:55, bsalomon wrote:
> On 2011/11/11 19:02:16, TomH wrote:
> > Although it makes sense here, seen in use without reading the header
comments
> > first Premul (or Alphamul) is very misleading. It's consistent with your
> naming
> > pattern, though, so may not need a redo.
>
> I verbized it as kMulRGBByAlpha. Better/worse?
It's growing on me. Ship it.
Tom
Issue 5373064: Do writepixels alpha-premul using gpu
(Closed)
Created 12 years, 10 months ago by bsalomon
Modified 12 years, 10 months ago
Reviewers: reed1, TomH
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 7