Fix convert to bool warning in VS

[TomH, 2011-11-10 14:59:14]

LGTM.

(IIRC the VS warning is a performance warning - does this really fix the
(absolutely negligible, as far as I can tell) performance issue that VS is
complaining about, or just mask it?)

[bsalomon, 2011-11-10 15:21:43]

I looked at the disassembly of:

SkBool8     isRadial2PosRoot() const { return fRadial2PosRoot; }

vs

bool     isRadial2PosRoot() const { return SkToBool(fRadial2PosRoot); }

In both cases checking the return value turns into:
cmp byte ptr [<reg>+48h], 0

Maybe it makes a difference if the type being cast is int instead of
SkBool8 (aka uint8_t)



On Thu, Nov 10, 2011 at 9:59 AM, <tomhudson@google.com> wrote:

> LGTM.
>
> (IIRC the VS warning is a performance warning - does this really fix the
> (absolutely negligible, as far as I can tell) performance issue that VS
> is complaining about, or just mask it?)
>
>
http://codereview.appspot.com/**5371051/<http://codereview.appspot.com/5371051/>
>

[bsalomon, 2011-11-10 15:49:21]

r2658