Added glTexSubImageD3DSurface2DANGLE.

Added glTexSubImageD3DSurface2DANGLE.

This blits a default pool D3D surface into a GL texture identified by texture ID. The D3D surface must have been created using the same D3D device that ANGLE is using.

No spec yet. I imagine the restrictions should be in line one those of StretchRect since that is what it will use.

Its initial use will be to blit NV16 and YU16 surfaces produced by DXVA into regular textures that can be composited with the rest of the web page. It is intended to be more generally useful though, hence the generic name, which is based on CGLTexImageIOSurface2D.

I considered making it support system pool and managed pool textures as well but they could just as esaily be locked and uploaded using the regular Tex*Image2D entry points.

The mipmap sample changes are not intended to be checked in.

[apatrick1, 2011-11-15 22:02:56]

Another one for you Daniel.

Thanks,

Al

[John Bauman, 2011-11-15 22:10:40]

http://codereview.appspot.com/5369113/diff/1005/src/libGLESv2/Texture.cpp
File src/libGLESv2/Texture.cpp (right):

http://codereview.appspot.com/5369113/diff/1005/src/libGLESv2/Texture.cpp#new...
src/libGLESv2/Texture.cpp:2021: getBlitter()->copy(source, sourceRect,
mImageArray[0].getFormat(), xoffset, destYOffset, dest);
Will this work? You need to do a stretchrect because the NV12 surfaces you get
from DXVA are offscreen plain and not textures, but Blit::copy only does
stretchrect if the source and dest formats are the same.

[apatrick1, 2011-11-15 22:17:29]

http://codereview.appspot.com/5369113/diff/1005/src/libGLESv2/Texture.cpp
File src/libGLESv2/Texture.cpp (right):

http://codereview.appspot.com/5369113/diff/1005/src/libGLESv2/Texture.cpp#new...
src/libGLESv2/Texture.cpp:2021: getBlitter()->copy(source, sourceRect,
mImageArray[0].getFormat(), xoffset, destYOffset, dest);
On 2011/11/15 22:10:40, John Bauman wrote:
> Will this work? You need to do a stretchrect because the NV12 surfaces you get
> from DXVA are offscreen plain and not textures, but Blit::copy only does
> stretchrect if the source and dest formats are the same.

I'm not sure exactly what contortions will be necessary. I hope having
Blit::copy call CheckDeviceFormatConversion and using StretchRect if supported
will work. But yeah, the output from DXVA is not textures. The patch to produce
the DXVA surfaces is still a work in progress.

[John Bauman, 2011-11-15 22:18:51]

On 2011/11/15 22:17:29, apatrick1 wrote:
> http://codereview.appspot.com/5369113/diff/1005/src/libGLESv2/Texture.cpp
> File src/libGLESv2/Texture.cpp (right):
> 
>
http://codereview.appspot.com/5369113/diff/1005/src/libGLESv2/Texture.cpp#new...
> src/libGLESv2/Texture.cpp:2021: getBlitter()->copy(source, sourceRect,
> mImageArray[0].getFormat(), xoffset, destYOffset, dest);
> On 2011/11/15 22:10:40, John Bauman wrote:
> > Will this work? You need to do a stretchrect because the NV12 surfaces you
get
> > from DXVA are offscreen plain and not textures, but Blit::copy only does
> > stretchrect if the source and dest formats are the same.
> 
> I'm not sure exactly what contortions will be necessary. I hope having
> Blit::copy call CheckDeviceFormatConversion and using StretchRect if supported
> will work. But yeah, the output from DXVA is not textures. The patch to
produce
> the DXVA surfaces is still a work in progress.
Ok, using CheckDeviceFormatConversion would work.

[dgkoch, 2011-12-21 15:41:35]

we're dropping this one at this point, right?

[apatrick1, 2011-12-21 18:58:12]

On 2011/12/21 15:41:35, dgkoch wrote:
> we're dropping this one at this point, right?

Closed