Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(319)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5359050
: Fix ./autogen.sh, ./configure and build errors. (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by
Peng
Modified:
14 years, 1 month ago
Reviewers:
hsumita
CC:
Yusuke Sato, bryeung
Base URL:
git://github.com/hsumita/libpyzy.git@master
Visibility:
Public.
Description
Fix ./autogen.sh, ./configure and build errors. BUG=./autogen.sh, ./configure and make errors TEST=./autogen.sh && make
Patch Set 1
#
Patch Set 2 : Fix file headers
#
Patch Set 3 : Rebase on HEAD
#
Created:
14 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+17860 lines, --1 lines
)
Patch
M
data/.gitignore
View
1 chunk
+0 lines, -1 line
0 comments
Download
A
data/db/android/Makefile.am
View
1
1 chunk
+57 lines, -0 lines
0 comments
Download
A
data/db/android/README
View
1 chunk
+2 lines, -0 lines
0 comments
Download
A
data/db/android/create_db.py
View
1 chunk
+83 lines, -0 lines
0 comments
Download
A
data/db/android/create_valid_hanzi.py
View
1 chunk
+17 lines, -0 lines
0 comments
Download
A
data/db/android/id.py
View
1 chunk
+1 line, -0 lines
0 comments
Download
A
data/db/android/pydict.py
View
1 chunk
+1 line, -0 lines
0 comments
Download
A
data/db/android/rawdict_utf16_65105_freq.txt
View
0 chunks
+-1 lines, --1 lines
0 comments
Download
A
data/db/android/valid_hanzi.py
View
1 chunk
+16469 lines, -0 lines
0 comments
Download
A
data/db/android/valid_utf16.txt
View
0 chunks
+-1 lines, --1 lines
0 comments
Download
A
data/db/create_index.sql
View
1 chunk
+68 lines, -0 lines
0 comments
Download
A
data/db/open-phrase/Makefile.am
View
1
1 chunk
+55 lines, -0 lines
0 comments
Download
A
m4/as-version.m4
View
1 chunk
+71 lines, -0 lines
0 comments
Download
A
m4/boost.m4
View
1 chunk
+1038 lines, -0 lines
0 comments
Download
Messages
Total messages: 2
Expand All Messages
|
Collapse All Messages
Peng
14 years, 1 month ago (2011-11-09 00:57:25 UTC)
#1
Sign in
to reply to this message.
hsumita
On 2011/11/09 00:57:25, Peng wrote: LGTM
14 years, 1 month ago (2011-11-09 02:33:00 UTC)
#2
On 2011/11/09 00:57:25, Peng wrote: LGTM
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 5359050: Fix ./autogen.sh, ./configure and build errors. (Closed)
Created 14 years, 1 month ago by Peng
Modified 14 years, 1 month ago
Reviewers: hsumita
Base URL: git://github.com/hsumita/libpyzy.git@master
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b