Issue 5354049: Update files to use SK_BUILD_FOR_ANDROID.

Issue 5354049: Update files to use SK_BUILD_FOR_ANDROID. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by DerekS

Modified:
13 years, 2 months ago

Reviewers:
epoger, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Update files to use SK_BUILD_FOR_ANDROID. This CL also removes any unecessary references to the ANDROID definition. Committed: http://code.google.com/p/skia/source/detail?r=2629

Patch Set 1 #

Total comments: 9

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -254 lines)			Patch
M	bench/benchmain.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/common_conditions.gypi	View	1 chunk	+1 line, -1 line	1 comment	Download
M	gyp/core.gyp	View	1 chunk	+2 lines, -0 lines	1 comment	Download
M	include/core/SkCanvas.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkDevice.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkDraw.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkFontHost.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkPaint.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/core/SkPath.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	include/core/SkPixelRef.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkRegion.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkTRegistry.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkThread_platform.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/core/SkUtils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/effects/SkPorterDuff.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrConfig.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/utils/SkCamera.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/views/SkWindow.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	samplecode/SampleApp.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/animator/SkDisplayEvent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkBitmapProcState_filter.h	View	1 chunk	+0 lines, -6 lines	1 comment	Download
M	src/core/SkCanvas.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkDevice.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkDraw.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkMemory_stdlib.cpp	View	1 chunk	+0 lines, -6 lines	1 comment	Download
M	src/core/SkPaint.cpp	View	5 chunks	+8 lines, -8 lines	0 comments	Download
M	src/core/SkPath.cpp	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/core/SkPicturePlayback.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/core/SkPicturePlayback.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkPixelRef.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkRegion.cpp	View	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/core/SkUtils.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkBlurDrawLooper.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/effects/SkPorterDuff.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/opts/SkBitmapProcState_opts_arm.cpp	View	1 chunk	+0 lines, -4 lines	1 comment	Download
M	src/opts/SkBlitRow_opts_arm.cpp	View	2 chunks	+1 line, -5 lines	1 comment	Download
M	src/ports/SkDebug_android.cpp	View	1 chunk	+3 lines, -16 lines	1 comment	Download
D	src/ports/SkOSEvent_android.cpp	View	1 chunk	+0 lines, -147 lines	1 comment	Download
D	src/ports/SkOSEvent_dummy.cpp	View	1 chunk	+0 lines, -20 lines	1 comment	Download
M	src/utils/SkCamera.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

epoger

13 years, 2 months ago (2011-11-08 18:26:00 UTC) #2

http://codereview.appspot.com/5354049/diff/1/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

http://codereview.appspot.com/5354049/diff/1/gyp/common_conditions.gypi#newco...
gyp/common_conditions.gypi:157: '-llog',
please put this change in a different CL

http://codereview.appspot.com/5354049/diff/1/gyp/core.gyp
File gyp/core.gyp (right):

http://codereview.appspot.com/5354049/diff/1/gyp/core.gyp#newcode346
gyp/core.gyp:346: '../src/ports/SkDebug_stdio.cpp',
please put these changes in a different CL

http://codereview.appspot.com/5354049/diff/1/src/core/SkBitmapProcState_filter.h
File src/core/SkBitmapProcState_filter.h (left):

http://codereview.appspot.com/5354049/diff/1/src/core/SkBitmapProcState_filte...
src/core/SkBitmapProcState_filter.h:10: #ifdef __arm__
please put this change in a different CL

http://codereview.appspot.com/5354049/diff/1/src/core/SkMemory_stdlib.cpp
File src/core/SkMemory_stdlib.cpp (left):

http://codereview.appspot.com/5354049/diff/1/src/core/SkMemory_stdlib.cpp#old...
src/core/SkMemory_stdlib.cpp:162: #ifdef ANDROID
please put these changes in a different CL

http://codereview.appspot.com/5354049/diff/1/src/opts/SkBitmapProcState_opts_...
File src/opts/SkBitmapProcState_opts_arm.cpp (left):

http://codereview.appspot.com/5354049/diff/1/src/opts/SkBitmapProcState_opts_...
src/opts/SkBitmapProcState_opts_arm.cpp:10: #ifdef ANDROID
please put this change in a different CL

http://codereview.appspot.com/5354049/diff/1/src/opts/SkBlitRow_opts_arm.cpp
File src/opts/SkBlitRow_opts_arm.cpp (left):

http://codereview.appspot.com/5354049/diff/1/src/opts/SkBlitRow_opts_arm.cpp#...
src/opts/SkBlitRow_opts_arm.cpp:9: #ifdef ANDROID
please put this change in a different CL

http://codereview.appspot.com/5354049/diff/1/src/ports/SkDebug_android.cpp
File src/ports/SkDebug_android.cpp (left):

http://codereview.appspot.com/5354049/diff/1/src/ports/SkDebug_android.cpp#ol...
src/ports/SkDebug_android.cpp:17: void Android_SkDebugf(const char* file, int
line, const char* function,
please put these changes in a different CL

http://codereview.appspot.com/5354049/diff/1/src/ports/SkOSEvent_android.cpp
File src/ports/SkOSEvent_android.cpp (left):

http://codereview.appspot.com/5354049/diff/1/src/ports/SkOSEvent_android.cpp#...
src/ports/SkOSEvent_android.cpp:2: /*
please put this change in a different CL

http://codereview.appspot.com/5354049/diff/1/src/ports/SkOSEvent_dummy.cpp
File src/ports/SkOSEvent_dummy.cpp (left):

http://codereview.appspot.com/5354049/diff/1/src/ports/SkOSEvent_dummy.cpp#ol...
src/ports/SkOSEvent_dummy.cpp:2: /*
please put this change in a different CL

Expand All Messages | Collapse All Messages