Issue 5347042: [GPU] Add explicit byte order and PM vs. UPM 8888 configs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5347042: [GPU] Add explicit byte order and PM vs. UPM 8888 configs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by bsalomon

Modified:
12 years, 8 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : wtf #

Patch Set 3 : fixes #

Patch Set 4 : new #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+427 lines, -139 lines)			Patch
M	bench/benchmain.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	experimental/iOSSampleApp/SkSampleUIView.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/gmmain.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	gm/texdata.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/GrColor.h	View	1 2 3	1 chunk	+5 lines, -8 lines	0 comments	Download
M	include/gpu/GrGLConfig.h	View	1 2 3	1 chunk	+0 lines, -10 lines	0 comments	Download
M	include/gpu/GrGLConfig_chrome.h	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	include/gpu/GrTypes.h	View	1 2 3	4 chunks	+62 lines, -7 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 2 3	3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/gpu/GrAtlas.cpp	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/GrContext.cpp	View	1 2 3	6 chunks	+85 lines, -12 lines	0 comments	Download
M	src/gpu/GrDrawTarget.cpp	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/gpu/GrGLProgram.h	View	1 2 3	3 chunks	+10 lines, -2 lines	0 comments	Download
M	src/gpu/GrGLProgram.cpp	View	1 2 3	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/gpu/GrGpu.h	View	1 2 3	4 chunks	+36 lines, -3 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1 2 3	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/gpu/GrGpuGL.h	View	1 2 3	4 chunks	+24 lines, -10 lines	0 comments	Download
M	src/gpu/GrGpuGL.cpp	View	1 2 3	7 chunks	+95 lines, -34 lines	0 comments	Download
M	src/gpu/GrGpuGLShaders.cpp	View	1 2 3	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 2 3	3 chunks	+30 lines, -9 lines	0 comments	Download
M	src/gpu/SkGr.cpp	View	1 2 3	1 chunk	+1 line, -5 lines	0 comments	Download
M	src/gpu/SkGrTexturePixelRef.cpp	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/ReadPixelsTest.cpp	View	1 2 3	9 chunks	+42 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

reed1

seems fine. Can you separate this into 2 CLs? I see some non-bitmap related changes ...

12 years, 8 months ago (2011-11-04 21:02:00 UTC) #2

Landed as revs 2613, 2615, and 2618

Expand All Messages | Collapse All Messages