Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(777)

Issue 5339051: When GL_RGBA readPixels are slow do swizzle using a draw then readPixels with GL_BGRA (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by bsalomon
Modified:
12 years, 7 months ago
Reviewers:
TomH
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -132 lines) Patch
M include/gpu/GrConfig.h View 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrGLConfig.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M include/gpu/GrGLConfig_chrome.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M include/gpu/GrSamplerState.h View 7 chunks +12 lines, -0 lines 0 comments Download
M include/gpu/GrTypes.h View 1 chunk +54 lines, -0 lines 0 comments Download
M src/gpu/GrContext.cpp View 3 chunks +19 lines, -11 lines 1 comment Download
M src/gpu/GrGLProgram.h View 2 chunks +17 lines, -10 lines 0 comments Download
M src/gpu/GrGLProgram.cpp View 6 chunks +22 lines, -15 lines 0 comments Download
M src/gpu/GrGLTexture.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/gpu/GrGpuGL.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/GrGpuGL.cpp View 1 7 chunks +87 lines, -86 lines 0 comments Download
M src/gpu/GrGpuGLShaders.cpp View 3 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3
bsalomon
ANGLE is horribly slow if we call glReadPixels with GL_RGBA. With this change swap R ...
12 years, 7 months ago (2011-11-08 15:59:08 UTC) #1
TomH
LGTM http://codereview.appspot.com/5339051/diff/2001/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (left): http://codereview.appspot.com/5339051/diff/2001/src/gpu/GrContext.cpp#oldcode59 src/gpu/GrContext.cpp:59: return GrContext::Create(kOpenGL_Shaders_GrEngine, 0); What happened to this?
12 years, 7 months ago (2011-11-08 19:08:12 UTC) #2
bsalomon
12 years, 7 months ago (2011-11-08 19:18:47 UTC) #3
On 2011/11/08 19:08:12, TomH wrote:
> LGTM
> 
> http://codereview.appspot.com/5339051/diff/2001/src/gpu/GrContext.cpp
> File src/gpu/GrContext.cpp (left):
> 
>
http://codereview.appspot.com/5339051/diff/2001/src/gpu/GrContext.cpp#oldcode59
> src/gpu/GrContext.cpp:59: return GrContext::Create(kOpenGL_Shaders_GrEngine,
0);
> What happened to this?

I have been meaning to remove it for a while. It was relevant to this change at
one moment in time, but now it's not. I'll revert that portion of the change
before committing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b