Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1078)

Issue 5332043: Import GMs as Samples (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by bsalomon
Modified:
13 years, 1 month ago
Reviewers:
mike3, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -327 lines) Patch
M gm/aarectmodes.cpp View 2 chunks +1 line, -1 line 0 comments Download
M gm/bitmapfilters.cpp View 2 chunks +1 line, -1 line 0 comments Download
M gm/bitmapscroll.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/blurs.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M gm/complexclip.cpp View 3 chunks +1 line, -5 lines 0 comments Download
M gm/complexclip2.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M gm/emptypath.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M gm/filltypes.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gm/filltypespersp.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/gm.h View 1 1 chunk +9 lines, -7 lines 0 comments Download
A gm/gm.cpp View 1 chunk +45 lines, -0 lines 0 comments Download
M gm/gmmain.cpp View 2 chunks +0 lines, -14 lines 0 comments Download
M gm/gradients.cpp View 2 chunks +4 lines, -7 lines 0 comments Download
M gm/hairmodes.cpp View 2 chunks +1 line, -2 lines 1 comment Download
M gm/lcdtext.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M gm/ninepatchstretch.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/nocolorbleed.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M gm/pathfill.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M gm/points.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M gm/poly2poly.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
M gm/shadertext.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M gm/shadows.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M gm/shapes.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M gm/strokerects.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/strokes.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/texdata.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
M gm/tilemodes.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M gm/tinybitmap.cpp View 2 chunks +1 line, -1 line 0 comments Download
M gm/xfermodes.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M gyp/SampleApp.gyp View 1 2 chunks +6 lines, -16 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +4 lines, -26 lines 0 comments Download
A gyp/gmslides.gypi View 1 chunk +37 lines, -0 lines 0 comments Download
A samplecode/GMSampleView.h View 1 1 chunk +50 lines, -0 lines 0 comments Download
M samplecode/OverView.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M samplecode/SampleApp.h View 1 chunk +1 line, -1 line 0 comments Download
M samplecode/SampleApp.cpp View 7 chunks +75 lines, -12 lines 0 comments Download
M samplecode/SampleCode.h View 2 chunks +47 lines, -5 lines 0 comments Download
D samplecode/SampleGM.cpp View 1 chunk +0 lines, -121 lines 0 comments Download

Messages

Total messages: 3
bsalomon
Copying and pasting from a Sample to a GM or vice-versa is so last week! ...
13 years, 1 month ago (2011-10-30 00:40:44 UTC) #1
bsalomon
13 years, 1 month ago (2011-10-30 19:06:44 UTC) #2
reed1
13 years, 1 month ago (2011-10-31 14:09:46 UTC) #3
as I noted in once instance, can we eliminate the call to setBGColor() if we're
setting it to white? I think we follow this in Samples...

LGTM

http://codereview.appspot.com/5332043/diff/2001/gm/hairmodes.cpp
File gm/hairmodes.cpp (left):

http://codereview.appspot.com/5332043/diff/2001/gm/hairmodes.cpp#oldcode95
gm/hairmodes.cpp:95: HairModesGM() {
since this is the default, do we need it here?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b