Issue 5330058: PDF: Fix bug in weak pointer pattern.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5330058: PDF: Fix bug in weak pointer pattern. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Steve VanDeBogart

Modified:
13 years ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

PDF: Fix bug in weak pointer pattern. For Canonicalized objects, only remove an object from the canonical list if it is the canonical object and not if it is an instance equal to the canonical object. BUG=381 TBR=reed@google.com Committed: http://code.google.com/p/skia/source/detail?r=2559

Patch Set 1 #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/pdf/SkPDFFont.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	src/pdf/SkPDFGraphicState.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages