Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(536)

Issue 5327046: Implemented new restrictions on nesting of structs in WebGL shaders. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by kbr1
Modified:
12 years, 6 months ago
Reviewers:
Alok Priyadarshi
CC:
angleproject-review_googlegroups.com, Zhenyao Mo, nicolas, dgkoch, VangelisK
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Implemented new restrictions on nesting of structs in WebGL shaders. Added previously missing check for embedded structs; even though these attempts would be caught by an underlying GLSL compiler, the shader validator should not let them through. BUG=http://code.google.com/p/angleproject/issues/detail?id=235 TEST=WebGL conformance tests Committed: http://code.google.com/p/angleproject/source/detail?r=809

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -477 lines) Patch
M src/common/version.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/ParseHelper.h View 3 chunks +28 lines, -3 lines 0 comments Download
M src/compiler/ParseHelper.cpp View 1 chunk +47 lines, -0 lines 0 comments Download
M src/compiler/SymbolTable.cpp View 1 2 chunks +16 lines, -0 lines 0 comments Download
M src/compiler/Types.h View 5 chunks +22 lines, -4 lines 0 comments Download
M src/compiler/glslang.y View 3 chunks +10 lines, -4 lines 0 comments Download
M src/compiler/glslang_tab.cpp View 40 chunks +469 lines, -465 lines 0 comments Download

Messages

Total messages: 3
kbr1
The new limitations are specified here: http://www.khronos.org/registry/webgl/specs/latest/ The new code has been verified against tests ...
12 years, 6 months ago (2011-10-26 23:30:05 UTC) #1
Alok Priyadarshi
lgtm just a couple nits. http://codereview.appspot.com/5327046/diff/1/src/compiler/SymbolTable.cpp File src/compiler/SymbolTable.cpp (right): http://codereview.appspot.com/5327046/diff/1/src/compiler/SymbolTable.cpp#newcode77 src/compiler/SymbolTable.cpp:77: empty namespace block http://codereview.appspot.com/5327046/diff/1/src/compiler/SymbolTable.cpp#newcode89 ...
12 years, 6 months ago (2011-10-27 04:05:12 UTC) #2
kbr1
12 years, 6 months ago (2011-10-27 21:14:40 UTC) #3
http://codereview.appspot.com/5327046/diff/1/src/compiler/SymbolTable.cpp
File src/compiler/SymbolTable.cpp (right):

http://codereview.appspot.com/5327046/diff/1/src/compiler/SymbolTable.cpp#new...
src/compiler/SymbolTable.cpp:77: 
On 2011/10/27 04:05:13, Alok Priyadarshi wrote:
> empty namespace block

Whoops. Fixed.

http://codereview.appspot.com/5327046/diff/1/src/compiler/SymbolTable.cpp#new...
src/compiler/SymbolTable.cpp:89: for (TTypeList::const_iterator tl =
getStruct()->begin(); tl != getStruct()->end(); tl++) {
On 2011/10/27 04:05:13, Alok Priyadarshi wrote:
> tl++ -> ++tl

OK, but the postincrement is used elsewhere in this file.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b