Fixed fallback icons.

Fixed fallback icons.

1. Set 'ibus-keyboard' icon for IME off in non-GNOME theme.
People would think the application icon for non-GNONE classic desktop.
The themed icon is applied for GNOME icon theme only.

2. Set gtk-fallback-icon-theme as 'gnome'
ibus gtk panel needs gtk stock icons but some desktop does not load GNOME
icon theme. I assigned 'gnome' for gtk-fallback-icon-theme if it's none.

3. Use 'gtk-dialog-info' if 'gtk-info' is not found.
It seems the latest gtk2 does not have 'gtk-info' icon via pygtk2.

BUG=RH#711632
TEST=Linux desktop

[Peng, 2011-11-02 06:45:49]

http://codereview.appspot.com/5320066/diff/1/ibus/_config.py.in
File ibus/_config.py.in (right):

http://codereview.appspot.com/5320066/diff/1/ibus/_config.py.in#newcode52
ibus/_config.py.in:52: icon = fallback_icon
I don't understand why need this?

http://codereview.appspot.com/5320066/diff/1/ui/gtk/panel.py
File ui/gtk/panel.py (right):

http://codereview.appspot.com/5320066/diff/1/ui/gtk/panel.py#newcode484
ui/gtk/panel.py:484: item.set_image(_icon.IconWidget("gtk-dialog-info",
size[0]))
Does all gtk versions have gtk-dialog-info? If yes, maybe we should just use
gtk-dialog-info replace old one.

[fujiwara, 2011-11-02 07:13:24]

On 2011/11/02 06:45:49, Peng wrote:
> http://codereview.appspot.com/5320066/diff/1/ibus/_config.py.in
> File ibus/_config.py.in (right):
> 
> http://codereview.appspot.com/5320066/diff/1/ibus/_config.py.in#newcode52
> ibus/_config.py.in:52: icon = fallback_icon
> I don't understand why need this?

I got the feedback about the icon.
https://bugzilla.redhat.com/show_bug.cgi?id=717831
It seems people like to use 'input-keyboard-symbolic' in GNOME3 desktop only and
other applets use the different icons between GNOME2 theme and GNOME3 theme.
I think the code could be removed after ibus-gjs is integrated into gnome-shell
but probably I'd think to use 'input-keyboard-symbolic' when the icon theme is
'gnome' at the moment. GNOME2/GNOME3's theme is 'gnome', LXDE's theme is
'Fedora' and KDE's theme is 'oxygen'.
So probably I'd think it might be a good idea to use the different icons by
themes.

> 
> http://codereview.appspot.com/5320066/diff/1/ui/gtk/panel.py
> File ui/gtk/panel.py (right):
> 
> http://codereview.appspot.com/5320066/diff/1/ui/gtk/panel.py#newcode484
> ui/gtk/panel.py:484: item.set_image(_icon.IconWidget("gtk-dialog-info",
> size[0]))
> Does all gtk versions have gtk-dialog-info? If yes, maybe we should just use
> gtk-dialog-info replace old one.

OK, I checked gtk-dialog-info exists in GTK+ 2.2.0 gtkstock.h but gtk-info does
not.
Probably we could replace gtk-info with gtk-dialog-info simply.

[fujiwara, 2011-11-03 07:48:53]

On 2011/11/02 07:13:24, fujiwara wrote:
> On 2011/11/02 06:45:49, Peng wrote:
> > http://codereview.appspot.com/5320066/diff/1/ui/gtk/panel.py
> > File ui/gtk/panel.py (right):
> > 
> > http://codereview.appspot.com/5320066/diff/1/ui/gtk/panel.py#newcode484
> > ui/gtk/panel.py:484: item.set_image(_icon.IconWidget("gtk-dialog-info",
> > size[0]))
> > Does all gtk versions have gtk-dialog-info? If yes, maybe we should just use
> > gtk-dialog-info replace old one.
> 
> OK, I checked gtk-dialog-info exists in GTK+ 2.2.0 gtkstock.h but gtk-info
does
> not.
> Probably we could replace gtk-info with gtk-dialog-info simply.

Updated the patch.

[Peng, 2011-11-08 01:15:18]

http://codereview.appspot.com/5320066/diff/6001/ibus/_config.py.in
File ibus/_config.py.in (right):

http://codereview.appspot.com/5320066/diff/6001/ibus/_config.py.in#newcode51
ibus/_config.py.in:51: if settings.get_property('gtk-icon-theme-name') !=
'gnome':
Maybe better to use:

if settings.get_property('gtk-icon-theme-name') != 'gnome':
    return fallback_icon;

http://codereview.appspot.com/5320066/diff/6001/ibus/_config.py.in#newcode55
ibus/_config.py.in:55: icon = fallback_icon
    return fallback_icon

[fujiwara, 2011-11-08 01:29:04]

On 2011/11/08 01:15:18, Peng wrote:
> http://codereview.appspot.com/5320066/diff/6001/ibus/_config.py.in
> File ibus/_config.py.in (right):
> 
> http://codereview.appspot.com/5320066/diff/6001/ibus/_config.py.in#newcode51
> ibus/_config.py.in:51: if settings.get_property('gtk-icon-theme-name') !=
> 'gnome':
> Maybe better to use:
> 
> if settings.get_property('gtk-icon-theme-name') != 'gnome':
>     return fallback_icon;
> 
> http://codereview.appspot.com/5320066/diff/6001/ibus/_config.py.in#newcode55
> ibus/_config.py.in:55: icon = fallback_icon
>     return fallback_icon

OK, I updated the patch.

[Peng, 2011-11-08 01:37:43]

lgtm