Refactoring APIs.

Refactoring APIs.

- Add many APIs to replace processKeyEvent.
- Remove pager related codes.

BUG=None
TEST=Run a test

[Peng, 2011-11-01 02:17:59]

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.cc
File src/PyZyBopomofoContext.cc (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.cc#ne...
src/PyZyBopomofoContext.cc:266: bopomofo += bopomofo_char[keyvalToBopomofo
(*i)];
Looks like it could be a local variable instead of member variable.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h
File src/PyZyBopomofoContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
src/PyZyBopomofoContext.h:38: /* API of InputContext */
Are they virtual functions? Please add virtual keyboard. I think the readability
will be better.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
src/PyZyBopomofoContext.h:56: bool selectCandidate (unsigned int i)
Are they virtual functions? I think it is better to not put implementations of
virtual functions in header file.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
src/PyZyBopomofoContext.h:90: std::wstring bopomofo;
m_bopomofo?

http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h
File src/PyZyDoublePinyinContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h...
src/PyZyDoublePinyinContext.h:43: bool moveCursorLeft (void);
Are they virtual function? I suggestioln add virtual keyword. I think the
readability will be better.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyFullPinyinContext.h
File src/PyZyFullPinyinContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyFullPinyinContext.h#n...
src/PyZyFullPinyinContext.h:39: 
ditto

http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h
File src/PyZyInputContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h#newcode86
src/PyZyInputContext.h:86: virtual void bopomofoSelectMode () = 0;
Why need expose bopomofo related methods in InputContext? Is it possible to
avoid it?

[hsumita, 2011-11-01 08:45:12]

I modify PyZyConfig to export readDefaultValues().

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.cc
File src/PyZyBopomofoContext.cc (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.cc#ne...
src/PyZyBopomofoContext.cc:266: bopomofo += bopomofo_char[keyvalToBopomofo
(*i)];
On 2011/11/01 02:17:59, Peng wrote:
> Looks like it could be a local variable instead of member variable.

Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h
File src/PyZyBopomofoContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
src/PyZyBopomofoContext.h:38: /* API of InputContext */
On 2011/11/01 02:17:59, Peng wrote:
> Are they virtual functions? Please add virtual keyboard. I think the
readability
> will be better.

Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
src/PyZyBopomofoContext.h:56: bool selectCandidate (unsigned int i)
On 2011/11/01 02:17:59, Peng wrote:
> Are they virtual functions? I think it is better to not put implementations of
> virtual functions in header file.

Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
src/PyZyBopomofoContext.h:90: std::wstring bopomofo;
It is removed. Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h
File src/PyZyDoublePinyinContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h...
src/PyZyDoublePinyinContext.h:43: bool moveCursorLeft (void);
On 2011/11/01 02:17:59, Peng wrote:
> Are they virtual function? I suggestioln add virtual keyword. I think the
> readability will be better.

Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h...
src/PyZyDoublePinyinContext.h:43: bool moveCursorLeft (void);
On 2011/11/01 02:17:59, Peng wrote:
> Are they virtual function? I suggestioln add virtual keyword. I think the
> readability will be better.

Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyFullPinyinContext.h
File src/PyZyFullPinyinContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyFullPinyinContext.h#n...
src/PyZyFullPinyinContext.h:39: 
On 2011/11/01 02:17:59, Peng wrote:
> ditto

Done.

http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h
File src/PyZyInputContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h#newcode86
src/PyZyInputContext.h:86: virtual void bopomofoSelectMode () = 0;
Unfortunately, the behavior of BopomofoContext::commit() is depends on
select_mode.

If we call commit() with select_mode, we can input bopomofo. On the other hand,
we call commit() without select_mode, we can input alphabet.

manabe@ said that bopomofo is used as echo-word in Taiwan, so we should provides
the methods to input bopomofo.

If you prefer to remove this function, How about create new accessors like
"restTextAsAscii()"? If we provides it, we can remove bopmofoSelectMode() and
users of libpyzy can determin the behavior.

[Peng, 2011-11-02 00:10:01]

On 2011/11/01 08:45:12, hsumita wrote:
> I modify PyZyConfig to export readDefaultValues().
> 
> http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.cc
> File src/PyZyBopomofoContext.cc (right):
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.cc#ne...
> src/PyZyBopomofoContext.cc:266: bopomofo += bopomofo_char[keyvalToBopomofo
> (*i)];
> On 2011/11/01 02:17:59, Peng wrote:
> > Looks like it could be a local variable instead of member variable.
> 
> Done.
> 
> http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h
> File src/PyZyBopomofoContext.h (right):
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
> src/PyZyBopomofoContext.h:38: /* API of InputContext */
> On 2011/11/01 02:17:59, Peng wrote:
> > Are they virtual functions? Please add virtual keyboard. I think the
> readability
> > will be better.
> 
> Done.
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
> src/PyZyBopomofoContext.h:56: bool selectCandidate (unsigned int i)
> On 2011/11/01 02:17:59, Peng wrote:
> > Are they virtual functions? I think it is better to not put implementations
of
> > virtual functions in header file.
> 
> Done.
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyBopomofoContext.h#new...
> src/PyZyBopomofoContext.h:90: std::wstring bopomofo;
> It is removed. Done.
> 
> http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h
> File src/PyZyDoublePinyinContext.h (right):
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h...
> src/PyZyDoublePinyinContext.h:43: bool moveCursorLeft (void);
> On 2011/11/01 02:17:59, Peng wrote:
> > Are they virtual function? I suggestioln add virtual keyword. I think the
> > readability will be better.
> 
> Done.
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyDoublePinyinContext.h...
> src/PyZyDoublePinyinContext.h:43: bool moveCursorLeft (void);
> On 2011/11/01 02:17:59, Peng wrote:
> > Are they virtual function? I suggestioln add virtual keyword. I think the
> > readability will be better.
> 
> Done.
> 
> http://codereview.appspot.com/5314054/diff/3017/src/PyZyFullPinyinContext.h
> File src/PyZyFullPinyinContext.h (right):
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyFullPinyinContext.h#n...
> src/PyZyFullPinyinContext.h:39: 
> On 2011/11/01 02:17:59, Peng wrote:
> > ditto
> 
> Done.
> 
> http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h
> File src/PyZyInputContext.h (right):
> 
>
http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h#newcode86
> src/PyZyInputContext.h:86: virtual void bopomofoSelectMode () = 0;
> Unfortunately, the behavior of BopomofoContext::commit() is depends on
> select_mode.
> 
> If we call commit() with select_mode, we can input bopomofo. On the other
hand,
> we call commit() without select_mode, we can input alphabet.
> 
> manabe@ said that bopomofo is used as echo-word in Taiwan, so we should
provides
> the methods to input bopomofo.
> 
> If you prefer to remove this function, How about create new accessors like
> "restTextAsAscii()"? If we provides it, we can remove bopmofoSelectMode() and
> users of libpyzy can determin the behavior.

Did you upload your changes?

[hsumita, 2011-11-02 02:43:10]

> Did you upload your changes?

Sorry. I upload a CL now.

[Peng, 2011-11-02 06:52:44]

http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h
File src/PyZyInputContext.h (right):

http://codereview.appspot.com/5314054/diff/3017/src/PyZyInputContext.h#newcode86
src/PyZyInputContext.h:86: virtual void bopomofoSelectMode () = 0;
On 2011/11/01 08:45:12, hsumita wrote:
> Unfortunately, the behavior of BopomofoContext::commit() is depends on
> select_mode.
> 
> If we call commit() with select_mode, we can input bopomofo. On the other
hand,
> we call commit() without select_mode, we can input alphabet.
> 
> manabe@ said that bopomofo is used as echo-word in Taiwan, so we should
provides
> the methods to input bopomofo.
> 
> If you prefer to remove this function, How about create new accessors like
> "restTextAsAscii()"? If we provides it, we can remove bopmofoSelectMode() and
> users of libpyzy can determin the behavior.

Does pinyin have similar problem?
Maybe we could add a parameter type(or mode) to commit() function?

We could define type like:
TYPE_RAW - commit raw input
TYPE_PHONETIC - commit pinyin or bopomofo
TYPE_CONVERTED -  commit chinese character,
... etc

[hsumita, 2011-11-08 06:25:52]

> Does pinyin have similar problem?
> Maybe we could add a parameter type(or mode) to commit() function?
> 
> We could define type like:
> TYPE_RAW - commit raw input
> TYPE_PHONETIC - commit pinyin or bopomofo
> TYPE_CONVERTED -  commit chinese character,
> ... etc

I implement these.
Please review.

[Peng Huang, 2011-11-08 16:04:25]

On 2011/11/08 06:25:52, hsumita wrote:
> > Does pinyin have similar problem?
> > Maybe we could add a parameter type(or mode) to commit() function?
> > 
> > We could define type like:
> > TYPE_RAW - commit raw input
> > TYPE_PHONETIC - commit pinyin or bopomofo
> > TYPE_CONVERTED -  commit chinese character,
> > ... etc
> 
> I implement these.
> Please review.

lgtm