Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6805)

Issue 5312056: Fixes all duplicate declarations of Flag #'transparent (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 5 months ago by MikeSol
Modified:
12 years, 5 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fixes all duplicate declarations of Flag #'transparent

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -78 lines) Patch
M Documentation/es/learning/tweaks.itely View 2 chunks +0 lines, -2 lines 0 comments Download
M Documentation/es/notation/ancient.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 2 chunks +0 lines, -2 lines 0 comments Download
M Documentation/ja/notation/changing-defaults.itely View 2 chunks +0 lines, -2 lines 0 comments Download
M Documentation/learning/tweaks.itely View 2 chunks +0 lines, -2 lines 0 comments Download
M Documentation/notation/ancient.itely View 1 chunk +0 lines, -1 line 0 comments Download
M Documentation/notation/changing-defaults.itely View 2 chunks +0 lines, -2 lines 0 comments Download
M Documentation/snippets/changing-fret-orientations.ly View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/customizing-fretboard-fret-diagrams.ly View 1 chunk +1 line, -0 lines 0 comments Download
M Documentation/snippets/defining-predefined-fretboards-for-other-instruments.ly View 1 chunk +0 lines, -57 lines 0 comments Download
M Documentation/snippets/guitar-slides.ly View 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/new/guitar-slides.ly View 2 chunks +1 line, -2 lines 1 comment Download
M input/regression/grid-lines.ly View 1 chunk +0 lines, -1 line 0 comments Download
M ly/gregorian.ly View 1 chunk +0 lines, -1 line 0 comments Download
M ly/property-init.ly View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3
Graham Percival (old account)
remove the version number change to 2.15.11, then please push. http://codereview.appspot.com/5312056/diff/1/Documentation/snippets/new/guitar-slides.ly File Documentation/snippets/new/guitar-slides.ly (right): http://codereview.appspot.com/5312056/diff/1/Documentation/snippets/new/guitar-slides.ly#newcode1 ...
12 years, 5 months ago (2011-10-25 12:11:29 UTC) #1
mike_apollinemike.com
On Oct 25, 2011, at 2:11 PM, percival.music.ca@gmail.com wrote: > remove the version number change ...
12 years, 5 months ago (2011-10-25 12:17:42 UTC) #2
mike_apollinemike.com
12 years, 5 months ago (2011-10-25 15:48:33 UTC) #3
On Oct 25, 2011, at 2:17 PM, mike@apollinemike.com wrote:

> On Oct 25, 2011, at 2:11 PM, percival.music.ca@gmail.com wrote:
> 
>> remove the version number change to 2.15.11, then please push.
>> 
>> 
>>
http://codereview.appspot.com/5312056/diff/1/Documentation/snippets/new/guita...
>> File Documentation/snippets/new/guitar-slides.ly (right):
>> 
>>
http://codereview.appspot.com/5312056/diff/1/Documentation/snippets/new/guita...
>> Documentation/snippets/new/guitar-slides.ly:1: \version "2.15.11"
>> why this change?
>> 
>> http://codereview.appspot.com/5312056/
> 
> 
> Hey Graham,
> 
> I'll be able to push once I get the dev/staging thing figured out.  Sorry that
that's taking me some time, but I'm not well versed enough in git to know how to
get it right w/o help.
> 
> If you have any ideas on how to get that up and running (I sent out an e-mail
a bit ago w/ the steps I took and where I wound up), I'd appreciate it!
> 
> Cheers,
> MS

Re-hay Graham,

None of these changes apply on top of dev/staging.  I'm not sure why, but to not
lose time, I'm doing a full doc build on master right now with the patch
applied.  If it goes through, do you want me to push the patch?  Otherwise, I'll
reset my HEAD on master back a notch and investigate what's going on in
dev/staging.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b