Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16059)

Issue 5312050: Rename \markuplines to \markuplist (before running convert-ly) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 6 months ago by dak
Modified:
12 years, 5 months ago
Reviewers:
mike, Bertrand Bordage
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Rename \markuplines to \markuplist (before running convert-ly) This inconsistency has been annoying me for years. Don't forget to run scripts/auxiliar/update-with-convert-ly in input/regression and Documentation before doing the checks.

Patch Set 1 #

Patch Set 2 : This is the patch to be checked, including the run of update-with-convert-ly #

Unified diffs Side-by-side diffs Delta from patch set Stats (+333 lines, -323 lines) Patch
M Documentation/de/extending/programming-interface.itely View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/de/notation/input.itely View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/de/notation/notation-appendices.itely View 1 25 chunks +48 lines, -48 lines 0 comments Download
M Documentation/de/notation/text.itely View 1 5 chunks +10 lines, -10 lines 0 comments Download
M Documentation/es/extending/programming-interface.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/es/notation/input.itely View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/es/notation/notation-appendices.itely View 1 26 chunks +50 lines, -50 lines 0 comments Download
M Documentation/es/notation/text.itely View 1 5 chunks +10 lines, -10 lines 0 comments Download
M Documentation/extending/programming-interface.itely View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Documentation/fr/notation/input.itely View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/fr/notation/notation-appendices.itely View 1 26 chunks +50 lines, -50 lines 0 comments Download
M Documentation/fr/notation/text.itely View 1 4 chunks +11 lines, -11 lines 0 comments Download
M Documentation/included/special-characters.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/ja/notation/input.itely View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/ja/notation/text.itely View 1 5 chunks +10 lines, -10 lines 0 comments Download
M Documentation/notation/input.itely View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Documentation/notation/notation-appendices.itely View 1 26 chunks +50 lines, -50 lines 0 comments Download
M Documentation/notation/text.itely View 1 5 chunks +10 lines, -10 lines 0 comments Download
M Documentation/snippets/markup-lines.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/snippets/table-of-contents.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M input/regression/bookparts.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/markup-lines.ly View 1 4 chunks +7 lines, -7 lines 0 comments Download
M input/regression/markup-lines-identifier.ly View 1 1 chunk +5 lines, -5 lines 0 comments Download
M input/regression/no-header.ly View 1 1 chunk +2 lines, -2 lines 0 comments Download
M input/regression/page-label-loose-column.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/page-spacing-markups.ly View 1 2 chunks +2 lines, -2 lines 0 comments Download
M input/regression/toc.ly View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lily/lily-lexer.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/parser.yy View 6 chunks +7 lines, -7 lines 0 comments Download
M ly/toc-init.ly View 2 chunks +2 lines, -2 lines 0 comments Download
M python/convertrules.py View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Bertrand Bordage
LGTM. You'll be happy to know that Mike and I are currently trying to get ...
12 years, 6 months ago (2011-10-23 21:08:09 UTC) #1
dak
On 2011/10/23 21:08:09, Bertrand Bordage wrote: > LGTM. You'll be happy to know that Mike ...
12 years, 6 months ago (2011-10-23 21:26:18 UTC) #2
mike_apollinemike.com
12 years, 6 months ago (2011-10-24 06:27:32 UTC) #3
On Oct 23, 2011, at 11:26 PM, dak@gnu.org wrote:

> Reviewers: Bertrand Bordage,
> 
> Message:
> On 2011/10/23 21:08:09, Bertrand Bordage wrote:
>> LGTM.  You'll be happy to know that Mike and I are currently trying to
> get rid
>> of \markuplines, so that there will only be a \markup command.
> 
> No, I am not happy, since for example fret markings in tabulatures are a
> perfect match for markup lists (and calling them markuplines is quite
> obscuring this wonderful way of defining them).

The idea is not to get rid of the functionality, but rather the nomenclatural
distinction.  The problem is that, in LilyPond markup-speak, there is not a
clear division between creating content, shaping content, and laying content
out.  Markups commands like \simple, \note etc. deal with either the creation of
content.  \italic, \bold etc. deal with its shaping.  And \justify, \line deal
with its layout on the page.  markuplist (née markuplist) is a particular
manifestation of this problem on the page level that implements something not
unlike Java Swing's box layout (fancier because it allows for page breaks).  But
one could imagine a host of layout managers that deal with the layout of markups
(and scores) on the page, and it would not be a good idea to hardcode these into
the parser (markuphorizontallist,
markuplistexceptwhenmarkupislargerthanthreecentimeterswideinwhichcaseitshouldnotbealist,
etc. as commands).  Rather, \markup should be the only command in the game, and
all of the layout managers should be declared within the markup bloc.

It seems like a good representation of any markup, be it top-level or in a text
script, would be a Prob that has three variables:

SCM layout_manager_
vector<SCM> transformations_
vector<SCM> elements_

\markup { \column { \italic foo bar }} would use line as its layout manager and
have two elements, one markup that used nothing as its layout manager (markups
with 1 element cannot have layout managers) and had no transformations and one
markup that used nothing as its layout manger and had an italic transformation.

In this representation, box-layout-across-pages could be a layout manager that
works like markuplines.  The page breaker would take all top level markups,
check the layout managers, and automatically create chunks based on the layout
manager being used.

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b