Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(57)

Issue 5312047: code review 5312047: goprotobuf: be honest about types in encode helpers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by r
Modified:
14 years ago
Reviewers:
CC:
golang-dev, gri
Visibility:
Public.

Description

goprotobuf: be honest about types in encode helpers

Patch Set 1 #

Patch Set 2 : diff -r 055b4de5e001 https://goprotobuf.googlecode.com/hg #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M proto/encode.go View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://goprotobuf.googlecode.com/hg
14 years ago (2011-10-20 22:53:41 UTC) #1
gri
LGTM
14 years ago (2011-10-20 23:02:13 UTC) #2
r
14 years ago (2011-10-20 23:03:12 UTC) #3
*** Submitted as
http://code.google.com/p/goprotobuf/source/detail?r=e849e91f7cf1 ***

goprotobuf: be honest about types in encode helpers

R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5312047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b