Add ChromeOptions, which consolidates all the Chrome capabilities into

Add ChromeOptions, which consolidates all the Chrome capabilities into
one API.

[kkania1, 2011-10-20 00:43:05]

Let me know if you're too busy to take this on. I'm currently working on the
server side of things.

Couple questions about webdriver development:
-is license correct?
-any line length rules
-where should i put my unit test
-do you use an IDE? if so, is there an easy way to set it up correctly

Couple comments about change:
I might add local-specific logic to avoid copies and network stuff later. I
might also zip the whole capability up later too. I added the experimental
options stuff in case someone needs a new ChromeDriver option real quickly. I'm
not sure if it's a good idea.

[kkania1, 2011-10-24 17:04:24]

ping?

[jleyba, 2011-10-24 17:32:00]

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/chrome/ChromeDriver.java (right):

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:7: import
org.openqa.selenium.chrome.ChromeOptions;
This is not necessary; same package as this test.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:109: @Deprecated
Also add a @deprecated javadoc tag with instructions on what should be used
instead.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:131: @Deprecated
Also add a @deprecated javadoc tag with instructions on what should be used
instead.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:136: private static
Capabilities optionsToCapabilities(ChromeOptions options) {
Move this into ChromeOptions:
public DesiredCapabilities toCapabilities();

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/chrome/ChromeOptions.java (right):

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:18: // Copyright
2008 Google Inc.  All Rights Reserved.
Delete this

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:55: private
List<String> args = new ArrayList<String>();
= Lists.newArrayList();

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:57: private
List<File> extensionFiles = new ArrayList<File>();
= Lists.newArrayList();

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:59: private final
Map<String, String> experimentalOptions = new HashMap<String, String>();
= Maps.newHashMap();

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:74: *      
"load-extension=/path/to/unpacked_extension",
Please document whether the "--" prefix is necessary.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:80: public void
setArguments(List<String> arguments) {
Instead of setArguments, I think we should only offer addArguments

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:112: Map<String,
Object> options = new HashMap(experimentalOptions);
= Maps.newHashMap(experimentalOptions);

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:116:
options.put("args", args);
So is the "chrome.switches" capability being deprecated as well?

[kkania1, 2011-10-27 01:55:20]

Questions:
-any line length rules
-where should i put my unit test

I return a JSONObject instead of a String in toJson because I didn't see any
reason why I'd want to have a json string inside a json object.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/chrome/ChromeDriver.java (right):

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:7: import
org.openqa.selenium.chrome.ChromeOptions;
On 2011/10/24 17:32:00, jleyba wrote:
> This is not necessary; same package as this test.

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:109: @Deprecated
On 2011/10/24 17:32:00, jleyba wrote:
> Also add a @deprecated javadoc tag with instructions on what should be used
> instead.

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:131: @Deprecated
On 2011/10/24 17:32:00, jleyba wrote:
> Also add a @deprecated javadoc tag with instructions on what should be used
> instead.

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeDriver.java:136: private static
Capabilities optionsToCapabilities(ChromeOptions options) {
On 2011/10/24 17:32:00, jleyba wrote:
> Move this into ChromeOptions:
> public DesiredCapabilities toCapabilities();

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
File java/client/src/org/openqa/selenium/chrome/ChromeOptions.java (right):

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:18: // Copyright
2008 Google Inc.  All Rights Reserved.
On 2011/10/24 17:32:00, jleyba wrote:
> Delete this

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:55: private
List<String> args = new ArrayList<String>();
On 2011/10/24 17:32:00, jleyba wrote:
> = Lists.newArrayList();

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:57: private
List<File> extensionFiles = new ArrayList<File>();
On 2011/10/24 17:32:00, jleyba wrote:
> = Lists.newArrayList();

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:59: private final
Map<String, String> experimentalOptions = new HashMap<String, String>();
On 2011/10/24 17:32:00, jleyba wrote:
> = Maps.newHashMap();

Changed this.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:74: *      
"load-extension=/path/to/unpacked_extension",
On 2011/10/24 17:32:00, jleyba wrote:
> Please document whether the "--" prefix is necessary.

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:80: public void
setArguments(List<String> arguments) {
On 2011/10/24 17:32:00, jleyba wrote:
> Instead of setArguments, I think we should only offer addArguments

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:112: Map<String,
Object> options = new HashMap(experimentalOptions);
On 2011/10/24 17:32:00, jleyba wrote:
> = Maps.newHashMap(experimentalOptions);

Done.

http://codereview.appspot.com/5307047/diff/4/java/client/src/org/openqa/selen...
java/client/src/org/openqa/selenium/chrome/ChromeOptions.java:116:
options.put("args", args);
On 2011/10/24 17:32:00, jleyba wrote:
> So is the "chrome.switches" capability being deprecated as well?

All of the old-style caps are being deprecated. Is there a guideline of how long
they should be supported? All new Chrome-specific caps live under
chromeOptions.xxx. I changed switches to args just because switches seems like a
less used term.

[kkania1, 2011-11-04 18:10:53]

ping

[jleyba, 2011-11-11 18:02:17]

On 2011/11/04 18:10:53, kkania1 wrote:
> ping

patch LGTM

Have you released a version of chromedriver that supports these capabilities
yet?  I can submit as soon as you do

[jleyba, 2011-12-15 20:21:23]

Submitted in http://code.google.com/p/selenium/source/detail?r=15195

On 2011/11/11 18:02:17, jleyba wrote:
> On 2011/11/04 18:10:53, kkania1 wrote:
> > ping
> 
> patch LGTM
> 
> Have you released a version of chromedriver that supports these capabilities
> yet?  I can submit as soon as you do