Issue 5306063: Limit copied uniform and vertex attribute names to the implicit size of the

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5306063: Limit copied uniform and vertex attribute names to the implicit size of the (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by kbr1

Modified:
12 years, 6 months ago

Reviewers:
zmo, vangelis

CC:
angleproject-review_googlegroups.com, VangelisK

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Limit copied uniform and vertex attribute names to the implicit size of the buffers passed in. Increase the size of the buffer the client will allocate for mapped names to be equal to the maximum token length. BUG=http://code.google.com/p/angleproject/issues/detail?id=234 TEST=WebGL conformance test to be checked in soon Committed: http://code.google.com/p/angleproject/source/detail?r=804

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+70 lines, -28 lines)			Patch
M	src/build_angle.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/common/version.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler/Compiler.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/compiler/MapLongVariableNames.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/compiler/MapLongVariableNames.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/compiler/ShaderLang.cpp	View		5 chunks	+35 lines, -16 lines	0 comments	Download
A	src/compiler/preprocessor/length_limits.h	View		1 chunk	+21 lines, -0 lines	0 comments	Download
M	src/compiler/preprocessor/scanner.h	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	src/compiler/translator_common.vcproj	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

zmo

LGTM http://codereview.appspot.com/5306063/diff/1/src/build_angle.gyp File src/build_angle.gyp (right): http://codereview.appspot.com/5306063/diff/1/src/build_angle.gyp#newcode82 src/build_angle.gyp:82: 'compiler/preprocessor/length_limits.h', Please also add this to compiler/translator_common.vcproj

12 years, 6 months ago (2011-10-25 23:13:13 UTC) #3

kbr1

12 years, 6 months ago (2011-10-26 01:17:38 UTC) #5

http://codereview.appspot.com/5306063/diff/1/src/build_angle.gyp
File src/build_angle.gyp (right):

http://codereview.appspot.com/5306063/diff/1/src/build_angle.gyp#newcode82
src/build_angle.gyp:82: 'compiler/preprocessor/length_limits.h',
On 2011/10/25 23:13:13, zmo wrote:
> Please also add this to compiler/translator_common.vcproj

Done.

Expand All Messages | Collapse All Messages