Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 5303064: Adding Blogger sample command line application

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 10 months ago by Brett Morgan
Modified:
12 years, 10 months ago
Reviewers:
jcgregorio_google
CC:
google-api-python-client_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes per jcgregorio's review #

Patch Set 3 : And making it actually run... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -0 lines) Patch
A samples/blogger/blogger.py View 1 2 1 chunk +142 lines, -0 lines 0 comments Download
A samples/blogger/client_secrets.json View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3
jcgregorio_google
Sorry for the delay, I didn't see this when it first went up! With codereview.appspot.com ...
12 years, 10 months ago (2011-10-27 14:51:33 UTC) #1
Brett Morgan
Hi Joe, I've updated my code per your review comments. Please let me know if ...
12 years, 10 months ago (2011-10-31 06:33:01 UTC) #2
jcgregorio_google
12 years, 10 months ago (2011-10-31 14:24:15 UTC) #3
Committed at
http://code.google.com/p/google-api-python-client/source/detail?r=596868787e3...

On 2011/10/31 06:33:01, Brett Morgan wrote:
> Hi Joe,
> 
> I've updated my code per your review comments. Please let me know if there is
> anything else I need to clean up =)
> 
> brett
> 
> http://codereview.appspot.com/5303064/diff/1/samples/blogger/blogger.py
> File samples/blogger/blogger.py (right):
> 
>
http://codereview.appspot.com/5303064/diff/1/samples/blogger/blogger.py#newco...
> samples/blogger/blogger.py:60: FLOW = OAuth2WebServerFlow(
> On 2011/10/27 14:51:34, jcgregorio_google wrote:
> > Please use client_secrets.json support as demonstrated in the Buzz sample:
> > 
> >
>
http://code.google.com/p/google-api-python-client/source/browse/#hg%25252Fsam...
> 
> Done.
> 
>
http://codereview.appspot.com/5303064/diff/1/samples/blogger/blogger.py#newco...
> samples/blogger/blogger.py:122: while 'nextPageToken' in blogposts and not
> (blogposts['nextPageToken'] is None):
> On 2011/10/27 14:51:34, jcgregorio_google wrote:
> > Please use _next pagination:
> > 
> >  http://code.google.com/p/google-api-python-client/wiki/Pagination
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b