JAVA,CPP: libphonenumber 4.1.

JAVA,CPP: libphonenumber 4.1.

Committed: http://code.google.com/p/libphonenumber/source/detail?r=374

[lararennie, 2011-10-19 11:28:19]

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt
File java/release_notes.txt (right):

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode3
java/release_notes.txt:3: - Update metadata for countries with IDD "8~10" to
accept phone numbers where
It's not just metadata, there's also code changes for this.

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode7
java/release_notes.txt:7: - Add ShortNumberUtil and tests.
Perhaps say what it actually does

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode8
java/release_notes.txt:8: - Increase the maximum phone-number length overall
(now set to 16).
perhaps say "maximum phone-number length accepted when parsing"

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode10
java/release_notes.txt:10: * Metadata changes
Most of these are just adding emergency numbers, right? Can we split those out?
So it's like: metadata updates, and then afterwards "Emergency number
information also added to: "....

[philippe, 2011-10-19 13:59:47]

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt
File java/release_notes.txt (right):

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode3
java/release_notes.txt:3: - Update metadata for countries with IDD "8~10" to
accept phone numbers where
On 2011/10/19 11:28:19, lararennie wrote:
> It's not just metadata, there's also code changes for this.

Done.

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode7
java/release_notes.txt:7: - Add ShortNumberUtil and tests.
On 2011/10/19 11:28:19, lararennie wrote:
> Perhaps say what it actually does

Done.

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode8
java/release_notes.txt:8: - Increase the maximum phone-number length overall
(now set to 16).
On 2011/10/19 11:28:19, lararennie wrote:
> perhaps say "maximum phone-number length accepted when parsing"

Done.

[lararennie, 2011-10-19 14:13:16]

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt
File java/release_notes.txt (right):

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode10
java/release_notes.txt:10: * Metadata changes
On 2011/10/19 11:28:19, lararennie wrote:
> Most of these are just adding emergency numbers, right? Can we split those
out?
> So it's like: metadata updates, and then afterwards "Emergency number
> information also added to: "....

Did you see this one?

http://codereview.appspot.com/5303049/diff/2039/java/release_notes.txt
File java/release_notes.txt (right):

http://codereview.appspot.com/5303049/diff/2039/java/release_notes.txt#newcode7
java/release_notes.txt:7: - Add ShortNumberUtil dealing with international short
phone numbers, such as
dealing with -> to deal with

[philippe, 2011-10-20 08:59:12]

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt
File java/release_notes.txt (right):

http://codereview.appspot.com/5303049/diff/1/java/release_notes.txt#newcode10
java/release_notes.txt:10: * Metadata changes
On 2011/10/19 14:13:16, lararennie wrote:
> On 2011/10/19 11:28:19, lararennie wrote:
> > Most of these are just adding emergency numbers, right? Can we split those
> out?
> > So it's like: metadata updates, and then afterwards "Emergency number
> > information also added to: "....
> 
> Did you see this one?

Done.

http://codereview.appspot.com/5303049/diff/2039/java/release_notes.txt
File java/release_notes.txt (right):

http://codereview.appspot.com/5303049/diff/2039/java/release_notes.txt#newcode7
java/release_notes.txt:7: - Add ShortNumberUtil dealing with international short
phone numbers, such as
On 2011/10/19 14:13:16, lararennie wrote:
> dealing with -> to deal with

Done.

[lararennie, 2011-10-20 10:50:33]

LGTM