Issue 5302079: Test feed good_feed expires on Dec 31, 2011 - 60 days from now - causing unexpected warnings and te

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5302079: Test feed good_feed expires on Dec 31, 2011 - 60 days from now - causing unexpected warnings and te (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by bdferris1

Modified:
14 years, 3 months ago

Reviewers:
neun

Base URL:
http://googletransitdatafeed.googlecode.com/svn/trunk/

Visibility:
Public.

Description

The test feeds python/test/data/good_feed/ and python/test/data/googletransit/good_feed/ both expire on Dec. 31, 2011, which happens to be 60 days from today, causing a new "feed will soon expire" warning to be produced in validation and causing issues for a number of the tests. Details at http://code.google.com/p/googletransitdatafeed/issues/detail?id=312

Patch Set 1 #

Patch Set 2 : The initial patch was invalid. This one should be better. #

Total comments: 2

Patch Set 3 : Push expiration date even further #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
		python/test/data/good_feed/calendar.txt	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
		python/test/data/googletransit/good_feed/calendar.txt	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

bdferris1

The initial patch was invalid. This one should be better.

14 years, 3 months ago (2011-11-02 13:41:51 UTC) #2

neun

FYI http://codereview.appspot.com/5302079/diff/2001/python/test/data/good_feed/calendar.txt File python/test/data/good_feed/calendar.txt (right): http://codereview.appspot.com/5302079/diff/2001/python/test/data/good_feed/calendar.txt#newcode3 python/test/data/good_feed/calendar.txt:3: WE,0,0,0,0,0,1,1,20070101,20121231 shouldn't we increase the year even more ...

14 years, 3 months ago (2011-11-02 13:44:32 UTC) #3

bdferris1

http://codereview.appspot.com/5302079/diff/2001/python/test/data/good_feed/calendar.txt File python/test/data/good_feed/calendar.txt (right): http://codereview.appspot.com/5302079/diff/2001/python/test/data/good_feed/calendar.txt#newcode3 python/test/data/good_feed/calendar.txt:3: WE,0,0,0,0,0,1,1,20070101,20121231 On 2011/11/02 13:44:32, neun wrote: > shouldn't we ...

14 years, 3 months ago (2011-11-02 13:51:32 UTC) #5

LGTM

Expand All Messages | Collapse All Messages