Issue 5298065: Fix some issues which may cause crash likely.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5298065: Fix some issues which may cause crash likely. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by Peng

Modified:
12 years, 5 months ago

Reviewers:
Peng Wu

CC:
Yusuke Sato

Base URL:
git@github.com:ibus/ibus-pinyin.git@master

Visibility:
Public.

Description

Fix some issues which may cause crash likely. BUG=http://code.google.com/p/ibus/issues/detail?id=1325 TEST=Manually

Patch Set 2 : Fix review issues #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -30 lines)			Patch
	M	src/PYEnglishEditor.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/PYEnglishEditor.cc	View	1	7 chunks	+24 lines, -28 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng Wu

The code style gets improved. https://codereview.appspot.com/5298065/diff/1/src/PYEnglishEditor.cc File src/PYEnglishEditor.cc (right): https://codereview.appspot.com/5298065/diff/1/src/PYEnglishEditor.cc#newcode762 src/PYEnglishEditor.cc:762: return FALSE; use "return ...

12 years, 5 months ago (2011-10-26 06:33:00 UTC) #2

Peng

http://codereview.appspot.com/5298065/diff/1/src/PYEnglishEditor.cc File src/PYEnglishEditor.cc (right): http://codereview.appspot.com/5298065/diff/1/src/PYEnglishEditor.cc#newcode762 src/PYEnglishEditor.cc:762: return FALSE; On 2011/10/26 06:33:00, Peng Wu wrote: > ...

12 years, 5 months ago (2011-10-26 14:01:46 UTC) #3

lgtm

Expand All Messages | Collapse All Messages