Hey all, As part of project markup & at the suggestion of Nicolas Sceaux by ...
12 years, 6 months ago
(2011-10-20 13:11:05 UTC)
#1
Hey all,
As part of project markup & at the suggestion of Nicolas Sceaux by way of
Valentin's opera, I've implemented in-notes in LilyPond. These notes hover
above systems and come up a fair bit in vocal music.
It works, but I have one major and one semi-major snag that I'd like to run by
people. Please don't run the regtests on this yet until these snags are worked
out.
Semi-major-snag: get_footnotes_from_lines should only ever be called once and
should stash its results in the systems and/or probs. I'll figure out how to do
this in the near future.
Major snag. On about 1 out of every 5 runs of this patch, it leads to
way-too-big spacing. This is because the stencils of in notes are, for some
reason, registering infinite extents in page-spacing.cc when they're being
counted (check account_for_footnotes and you'll see that the value of the extent
for in_notes is occasionally really really really large). This is strange
because when the in_notes are added to the breaker
(System::get_in_notes_in_range), these extents are correct. I think it is an
issue with pointers and garbage collection of stencils - does anyone have any
intuition about this.
Here's a test file:
\version "2.15.15"
\header {
texidoc = "LilyPond does in-notes. The positioning of these notes can
be above or below the staff via the paper variable @code{in note direction}
and spaced via the variable @{in-note-padding}.
"
}
\relative c' {
\repeat unfold 5 {
\repeat unfold 20 { a\< b c d\! }
% activates the in-note
\once \override FootnoteItem #'footnote = ##f
\footnoteGrob #'NoteHead #'(0 . 0)
"" \markup { \box \fill-line { "this is a test this is a test"
} }
a b c d
\repeat unfold 20 { a b c d }
\autoFootnoteGrob #'NoteHead #'(-1 . 1) "foo bar foo bar"
a b c d
\repeat unfold 20 { a\< b c d\! }
}
}
I can't compile because of valgrind. Bertrand http://codereview.appspot.com/5293053/diff/12001/lily/include/page-layout-problem.hh File lily/include/page-layout-problem.hh (right): http://codereview.appspot.com/5293053/diff/12001/lily/include/page-layout-problem.hh#newcode100 lily/include/page-layout-problem.hh:100: Direction in_note_direction_; ...
12 years, 6 months ago
(2011-10-21 11:52:25 UTC)
#4
On 2011/10/21 23:49:26, Bertrand Bordage wrote: > Sorry for this total mistake. !ly_is_equal (..., SCM_EOL) ...
12 years, 6 months ago
(2011-10-22 00:36:25 UTC)
#12
On 2011/10/21 23:49:26, Bertrand Bordage wrote:
> Sorry for this total mistake. !ly_is_equal (..., SCM_EOL) should do it, then.
It is pretty pointless to use ly_is_equal instead of scm_is_eq on SCM_EOL, and
!scm_is_null (...) is prettier anyway.
On Oct 22, 2011, at 1:08 AM, percival.music.ca@gmail.com wrote: > > http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc > File lily/page-breaking.cc ...
12 years, 6 months ago
(2011-10-22 19:56:26 UTC)
#13
On Oct 22, 2011, at 1:08 AM, percival.music.ca@gmail.com wrote:
>
> http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc
> File lily/page-breaking.cc (right):
>
>
http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcod...
> lily/page-breaking.cc:189: old.in_note_heights_.begin (),
> old.in_note_heights_.end ());
> Why are we talking about C++ style?
>
> Run it through fix-cc.py. Whatever that produces is ok as far as this
> patch goes.
> (if something looks bad, then we can discuss modifying fix-cc.py in some
> way -- but that's a separate issue from whether we accept this patch or
> not.)
>
> http://codereview.appspot.com/5293053/
Running fix-cc.py, I got:
page-layout-problem.cc...
Invalid command line option: align-pointer=name
For help on options, type 'astyle -h'
astyle wasn't in the lilydev Ubuntu, so I used apt-get to get it. Maybe there's
a problem with versioning?
Cheers,
MS
On Sat, Oct 22, 2011 at 09:56:16PM +0200, mike@apollinemike.com wrote: > > Running fix-cc.py, I ...
12 years, 6 months ago
(2011-10-22 20:36:38 UTC)
#14
On Sat, Oct 22, 2011 at 09:56:16PM +0200, mike@apollinemike.com wrote:
>
> Running fix-cc.py, I got:
> astyle wasn't in the lilydev Ubuntu, so I used apt-get to get
> it. Maybe there's a problem with versioning?
You need version 2.02. It would be nice if the script warned if
you had a different version.
http://code.google.com/p/lilypond/issues/detail?id=1797
Cheers,
- Graham
On Oct 29, 2011, at 9:00 AM, dak@gnu.org wrote: >> > > Patch has been ...
12 years, 5 months ago
(2011-10-29 13:29:46 UTC)
#18
On Oct 29, 2011, at 9:00 AM, dak@gnu.org wrote:
>>
>
> Patch has been backed out. It broke the documentation build this
> morning. And it broke the documentation build with a line that Neil has
> already pointed out yesterday at noon. It is not that this particular
> mistake was unheard of.
>
> Since this kept the second in unfriendliness from accepting a patch
> series from the most unfriendly developer, consider the remarks to be
> expected as having been made.
>
> I have not checked in this particular instance, but in my experience
> "make doc-clean info" detects most documentation building failures while
> appearing somewhat faster than a web build.
>
> http://codereview.appspot.com/5293053/
New patch set uploaded.
Cheers,
MS
Issue 5293053: Sketch for in-notes.
(Closed)
Created 12 years, 6 months ago by MikeSol
Modified 12 years, 5 months ago
Reviewers: Bertrand Bordage, Graham Percival (old account), Neil Puttock, dak, mike_apollinemike.com, Graham Percival
Base URL:
Comments: 42
