Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(195)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
5293049
: Thread safety analysis: Refactoring of removeLocks and invalid lock warning
Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by
delesley
Modified:
9 years, 3 months ago
Reviewers:
Visibility:
Public.
Patch Set 1
#
Patch Set 2 : Code review fixes
#
Created:
13 years, 2 months ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+97 lines, -42 lines
)
Patch
M
include/clang/Basic/DiagnosticSemaKinds.td
View
1
1 chunk
+1 line, -1 line
0 comments
Download
M
lib/Analysis/ThreadSafety.cpp
View
1
14 chunks
+60 lines, -30 lines
0 comments
Download
M
lib/Sema/AnalysisBasedWarnings.cpp
View
1
2 chunks
+9 lines, -2 lines
0 comments
Download
M
test/SemaCXX/warn-thread-safety-analysis.cpp
View
1
2 chunks
+27 lines, -9 lines
0 comments
Download
Issue 5293049: Thread safety analysis: Refactoring of removeLocks and invalid lock warning
Created 13 years, 2 months ago by delesley
Modified 9 years, 3 months ago
Reviewers:
Base URL:
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b
