Issue 5271053: Move to using setuptools exclusively.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5271053: Move to using setuptools exclusively. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by jcgregorio_google

Modified:
12 years, 10 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Makefile #

Patch Set 3 : keep as a script, not a binary #

Patch Set 4 : change version #

Total comments: 1

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -469 lines)			Patch
M	bin/enable-app-engine-project	View		3 chunks	+5 lines, -4 lines	0 comments	Download
R	contrib/__init__.py	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
R	contrib/buzz/__init__.py	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
R	contrib/buzz/buzz_appengine.py	View	1 2	1 chunk	+0 lines, -173 lines	0 comments	Download
R	contrib/buzz/simple_wrapper.py	View	1 2	1 chunk	+0 lines, -82 lines	0 comments	Download
R	contrib_tests/__init__.py	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
R	contrib_tests/buzz/__init__.py	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
R	contrib_tests/buzz/test_simple_wrapper.py	View	1 2	1 chunk	+0 lines, -118 lines	0 comments	Download
R	contrib_tests/test_account.oacurl.properties	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download
M	expand-symlinks.py	View	1 2	3 chunks	+20 lines, -2 lines	1 comment	Download
M	setup.py	View	1 2 3	3 chunks	+14 lines, -20 lines	0 comments	Download
M	setup_oauth2client.py	View	1 2 3	1 chunk	+12 lines, -16 lines	0 comments	Download
R	setup_utils.py	View		1 chunk	+0 lines, -52 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

aiuto

12 years, 10 months ago (2011-10-18 18:37:51 UTC) #2

lgtm

http://codereview.appspot.com/5271053/diff/4002/expand-symlinks.py
File expand-symlinks.py (right):

http://codereview.appspot.com/5271053/diff/4002/expand-symlinks.py#newcode35
expand-symlinks.py:35: IGNORE_IN_SAMPLES = set(['apiclient', 'oauth2client',
'uritemplate'])
Is there any use for making these patterns rather than explicit?

Expand All Messages | Collapse All Messages