Issue 5263046: JAVA: Release InputStreams after using them.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5263046: JAVA: Release InputStreams after using them. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by Shaopeng

Modified:
14 years, 2 months ago

Reviewers:
philippe

CC:
lararennie

Base URL:
http://libphonenumber.googlecode.com/svn/trunk/

Visibility:
Public.

Description

JAVA: Release InputStreams after using them. Committed: http://code.google.com/p/libphonenumber/source/detail?r=373

Patch Set 2 : '' #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -3 lines)			Patch
	M	java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java	View	1	2 chunks	+13 lines, -1 line	0 comments	Download
	M	java/src/com/google/i18n/phonenumbers/geocoding/PhoneNumberOfflineGeocoder.java	View	1	3 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

philippe

LGTM. http://codereview.appspot.com/5263046/diff/1/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java File java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java (right): http://codereview.appspot.com/5263046/diff/1/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java#newcode629 java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java:629: private void close(InputStream in) { You could make ...

14 years, 2 months ago (2011-10-18 07:17:14 UTC) #1

Shaopeng

http://codereview.appspot.com/5263046/diff/1/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java File java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java (right): http://codereview.appspot.com/5263046/diff/1/java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java#newcode629 java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java:629: private void close(InputStream in) { On 2011/10/18 07:17:14, philippe ...

14 years, 2 months ago (2011-10-19 18:35:50 UTC) #2

Shaopeng

14 years, 2 months ago (2011-10-19 18:38:44 UTC) #3

Committed as r373.

On 2011/10/19 18:35:50, Shaopeng wrote:
>
http://codereview.appspot.com/5263046/diff/1/java/src/com/google/i18n/phonenu...
> File java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java (right):
> 
>
http://codereview.appspot.com/5263046/diff/1/java/src/com/google/i18n/phonenu...
> java/src/com/google/i18n/phonenumbers/PhoneNumberUtil.java:629: private void
> close(InputStream in) {
> On 2011/10/18 07:17:14, philippe wrote:
> > You could make this method and the one in the other file static, as you
never
> > use "this", which would also make its call faster.
> 
> Done.

Expand All Messages | Collapse All Messages