Cache currently-bound draw buffer.

Cache currently-bound draw buffer.

Avoids a hash table lookup


BUG=
TEST=webgl conformance tests

Committed: http://code.google.com/p/angleproject/source/detail?r=794

[nicolas, 2011-10-12 21:24:02]

http://codereview.appspot.com/5261042/diff/1/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

http://codereview.appspot.com/5261042/diff/1/src/libGLESv2/Context.cpp#newcod...
src/libGLESv2/Context.cpp:1034: mCachedDrawFramebuffer = NULL;
Unless there's a realistic scenario where one would end up calling
bindDrawFramebuffer() multiple times before getDrawBuffer() is called, you might
as well just call getFramebuffer(framebuffer) here and rename
mCachedDrawFramebuffer to mBoundDrawFramebuffer or something.
Context::getDrawFrameBuffer() could then always return mBoundDrawFramebuffer.

I believe you also need to set it to NULL on deleteFramebuffer() if the
currently bound one is the one being deleted.

[John Bauman, 2011-10-12 23:48:56]

http://codereview.appspot.com/5261042/diff/1/src/libGLESv2/Context.cpp
File src/libGLESv2/Context.cpp (right):

http://codereview.appspot.com/5261042/diff/1/src/libGLESv2/Context.cpp#newcod...
src/libGLESv2/Context.cpp:1034: mCachedDrawFramebuffer = NULL;
On 2011/10/12 21:24:02, nicolas wrote:
> Unless there's a realistic scenario where one would end up calling
> bindDrawFramebuffer() multiple times before getDrawBuffer() is called, you
might
> as well just call getFramebuffer(framebuffer) here and rename
> mCachedDrawFramebuffer to mBoundDrawFramebuffer or something.
> Context::getDrawFrameBuffer() could then always return mBoundDrawFramebuffer.

Ok, done.
> 
> I believe you also need to set it to NULL on deleteFramebuffer() if the
> currently bound one is the one being deleted.

We already bind framebuffer 0 if that happens.

[nicolas, 2011-10-13 14:08:06]

Looking good.

[dgkoch, 2011-10-13 18:03:39]

LGTM as well.