Update Python Sample for Prediction v1.4

[jcgregorio_google, 2011-10-12 19:37:52]

http://codereview.appspot.com/5252054/diff/1/samples/prediction/README.html
File samples/prediction/README.html (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/README.html#n...
samples/prediction/README.html:1: 
Please use only text README files. If you have HTML content that you want users
to see then host that on code.google.com and provide a link to it in the README
file.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/language_id.txt
File samples/prediction/language_id.txt (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/language_id.t...
samples/prediction/language_id.txt:1: 
This looks incorrect, like you have replaced the text file with the HTML page?

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction.dat
File samples/prediction/prediction.dat (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction.da...
samples/prediction/prediction.dat:1: {"_module": "oauth2client.client",
"_class": "OAuth2Credentials", "access_token":
"ya29.AHES6ZSRNOw2rqQle7wgNK5J5ojCQK3IDh0M8-HJ1ztQdA3ye2Cy0g", "token_uri":
"https://accounts.google.com/o/oauth2/token", "invalid": false, "client_id":
"433807057907.apps.googleusercontent.com", "client_secret":
"jigtZpMApkRxncxikFpR+SFg", "token_expiry": "2011-10-12T19:52:14Z",
"refresh_token": "1/WD8ZvT2WqtdWZuk4EKnVJOy8nDJFkbs4CGkHbvfgCf4", "user_agent":
"prediction-cmdline-sample/1.0"}
This should not be included. And you should go to
https://accounts.google.com/b/0/IssuedAuthSubTokens and revoke access to this
application so no one can steal your refresh_token.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_la...
File samples/prediction/prediction_language_id.py (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_la...
samples/prediction/prediction_language_id.py:66: FLOW = OAuth2WebServerFlow(
Please migrate to using client_secrets.json, follow the example in buzz.py

http://code.google.com/p/google-api-python-client/source/browse/#hg%2Fsamples...

Also make sure to include a default client_secrets.json as done in that sample
also.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_la...
samples/prediction/prediction_language_id.py:130: # We check the training job is
completed. If it is not it will return an error code.
80 chars

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_nu...
File samples/prediction/prediction_number.py (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_nu...
samples/prediction/prediction_number.py:25: $ python prediction.py
--model_id="foo" --data_file="bucket/object" --pmml_file="bucket/object"
80 chars

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_nu...
samples/prediction/prediction_number.py:66: FLOW = OAuth2WebServerFlow(
Same as prediction_language_id, migrate to client_secrets.json.

[thomasfu, 2011-10-12 20:45:12]

Updated the code.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/README.html
File samples/prediction/README.html (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/README.html#n...
samples/prediction/README.html:1: 
Updated.

On 2011/10/12 19:37:52, jcgregorio_google wrote:
> Please use only text README files. If you have HTML content that you want
users
> to see then host that on http://code.google.com and provide a link to it in
the README
> file.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/language_id.txt
File samples/prediction/language_id.txt (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/language_id.t...
samples/prediction/language_id.txt:1: 
Updated.

On 2011/10/12 19:37:52, jcgregorio_google wrote:
> This looks incorrect, like you have replaced the text file with the HTML page?

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction.dat
File samples/prediction/prediction.dat (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction.da...
samples/prediction/prediction.dat:1: {"_module": "oauth2client.client",
"_class": "OAuth2Credentials", "access_token":
"ya29.AHES6ZSRNOw2rqQle7wgNK5J5ojCQK3IDh0M8-HJ1ztQdA3ye2Cy0g", "token_uri":
"https://accounts.google.com/o/oauth2/token", "invalid": false, "client_id":
"433807057907.apps.googleusercontent.com", "client_secret":
"jigtZpMApkRxncxikFpR+SFg", "token_expiry": "2011-10-12T19:52:14Z",
"refresh_token": "1/WD8ZvT2WqtdWZuk4EKnVJOy8nDJFkbs4CGkHbvfgCf4", "user_agent":
"prediction-cmdline-sample/1.0"}
On 2011/10/12 19:37:52, jcgregorio_google wrote:
> This should not be included. And you should go to
> https://accounts.google.com/b/0/IssuedAuthSubTokens and revoke access to this
> application so no one can steal your refresh_token.

Done.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_nu...
File samples/prediction/prediction_number.py (right):

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_nu...
samples/prediction/prediction_number.py:25: $ python prediction.py
--model_id="foo" --data_file="bucket/object" --pmml_file="bucket/object"
On 2011/10/12 19:37:52, jcgregorio_google wrote:
> 80 chars

Done.

http://codereview.appspot.com/5252054/diff/1/samples/prediction/prediction_nu...
samples/prediction/prediction_number.py:66: FLOW = OAuth2WebServerFlow(
On 2011/10/12 19:37:52, jcgregorio_google wrote:
> Same as prediction_language_id, migrate to client_secrets.json.

Done.

[jcgregorio_google, 2011-10-13 14:16:25]

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/language_...
File samples/prediction/language_id.txt (right):

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/language_...
samples/prediction/language_id.txt:1: "French", "M. de Troisvilles, comme
s'appelait encore sa famille en Gascogne, ou M. de Tréville, comme il avait
fini par s'appeler lui-même à Paris, avait réellement commencé comme
d'Artagnan, c'est-à-dire sans un sou vaillant, mais avec ce fonds d'audace,
d'esprit et d'entendement qui fait que le plus pauvre gentillâtre gascon
reçoit souvent plus en ses espérances de l'héritage paternel que le plus
riche gentilhomme périgourdin ou berrichon ne reçoit en réalité. Sa bravoure
insolente, son bonheur plus insolent encore dans un temps où les coups
pleuvaient comme grêle, l'avaient hissé au sommet de cette échelle difficile
qu'on appelle la faveur de cour, et dont il avait escaladé quatre à quatre les
échelons."
Now it looks like there are encoding issues.

Did this file actually change or can we drop it from the CL?

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
File samples/prediction/prediction_language_id.py (right):

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
samples/prediction/prediction_language_id.py:25: $ python prediction.py
--model_id="foo" --data_file="bucket/object"
prediction.py -> prediction_language_id.py

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
File samples/prediction/prediction_number.py (right):

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
samples/prediction/prediction_number.py:25: $ python prediction.py
--model_id="foo" --data_file="bucket/object"
prediction.py -> prediction_number.py

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
samples/prediction/prediction_number.py:26: --pmml_file="bucket/object"
Also add a note here that they must they upload the number.csv and number.pmml
files.

[thomasfu, 2011-10-13 15:46:01]

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/language_...
File samples/prediction/language_id.txt (right):

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/language_...
samples/prediction/language_id.txt:1: "French", "M. de Troisvilles, comme
s'appelait encore sa famille en Gascogne, ou M. de Tréville, comme il avait
fini par s'appeler lui-même à Paris, avait réellement commencé comme
d'Artagnan, c'est-à-dire sans un sou vaillant, mais avec ce fonds d'audace,
d'esprit et d'entendement qui fait que le plus pauvre gentillâtre gascon
reçoit souvent plus en ses espérances de l'héritage paternel que le plus
riche gentilhomme périgourdin ou berrichon ne reçoit en réalité. Sa bravoure
insolente, son bonheur plus insolent encore dans un temps où les coups
pleuvaient comme grêle, l'avaient hissé au sommet de cette échelle difficile
qu'on appelle la faveur de cour, et dont il avait escaladé quatre à quatre les
échelons."
This change is unwanted, so I reverted this file.

On 2011/10/13 14:16:25, jcgregorio_google wrote:
> Now it looks like there are encoding issues.
> 
> Did this file actually change or can we drop it from the CL?

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
File samples/prediction/prediction_language_id.py (right):

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
samples/prediction/prediction_language_id.py:25: $ python prediction.py
--model_id="foo" --data_file="bucket/object"
On 2011/10/13 14:16:25, jcgregorio_google wrote:
> prediction.py -> prediction_language_id.py
> 

Done.

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
File samples/prediction/prediction_number.py (right):

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
samples/prediction/prediction_number.py:25: $ python prediction.py
--model_id="foo" --data_file="bucket/object"
On 2011/10/13 14:16:25, jcgregorio_google wrote:
> prediction.py -> prediction_number.py

Done.

http://codereview.appspot.com/5252054/diff/15001/samples/prediction/predictio...
samples/prediction/prediction_number.py:26: --pmml_file="bucket/object"
On 2011/10/13 14:16:25, jcgregorio_google wrote:
> Also add a note here that they must they upload the number.csv and number.pmml
> files.

Done.

[jcgregorio_google, 2011-10-14 13:22:54]

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/number.pmml
File samples/prediction/number.pmml (right):

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/number.pm...
samples/prediction/number.pmml:2: <Header copyright="Copyright (c) 2001, Oracle
Corporation.  All rights reserved.">
What exactly is copyrighted by Oracle?

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
File samples/prediction/prediction_language_id.py (right):

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
samples/prediction/prediction_language_id.py:53: from oauth2client.client import
OAuth2WebServerFlow
unused import

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
File samples/prediction/prediction_number.py (right):

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
samples/prediction/prediction_number.py:54: from oauth2client.client import
OAuth2WebServerFlow
unused import

[thomasfu, 2011-10-14 15:00:47]

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/number.pmml
File samples/prediction/number.pmml (right):

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/number.pm...
samples/prediction/number.pmml:2: <Header copyright="Copyright (c) 2001, Oracle
Corporation.  All rights reserved.">
No, definitely. We created this file.

Updated.


On 2011/10/14 13:22:54, jcgregorio_google wrote:
> What exactly is copyrighted by Oracle?

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
File samples/prediction/prediction_language_id.py (right):

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
samples/prediction/prediction_language_id.py:53: from oauth2client.client import
OAuth2WebServerFlow
On 2011/10/14 13:22:54, jcgregorio_google wrote:
> unused import

Done.

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
File samples/prediction/prediction_number.py (right):

http://codereview.appspot.com/5252054/diff/23001/samples/prediction/predictio...
samples/prediction/prediction_number.py:54: from oauth2client.client import
OAuth2WebServerFlow
On 2011/10/14 13:22:54, jcgregorio_google wrote:
> unused import

Done.

[jcgregorio_google, 2011-10-14 15:04:40]

LGTM

[jcgregorio_google, 2011-10-14 16:01:30]

On 2011/10/14 15:04:40, jcgregorio_google wrote:
> LGTM

Committed
http://code.google.com/p/google-api-python-client/source/detail?r=e54c13604f1...