Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1010)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 5250070: Move gpu/src -> src/gpu and gpu/include -> include/gpu (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by bsalomon
Modified:
13 years, 1 month ago
Reviewers:
epoger, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -33153 lines) Patch
D gpu/include/FlingState.h View 1 chunk +0 lines, -51 lines 0 comments Download
D gpu/include/GrAllocPool.h View 1 chunk +0 lines, -64 lines 0 comments Download
D gpu/include/GrAllocator.h View 1 chunk +0 lines, -249 lines 0 comments Download
D gpu/include/GrAtlas.h View 1 chunk +0 lines, -84 lines 0 comments Download
D gpu/include/GrClip.h View 1 chunk +0 lines, -141 lines 0 comments Download
D gpu/include/GrClipIterator.h View 1 chunk +0 lines, -80 lines 0 comments Download
D gpu/include/GrColor.h View 1 chunk +0 lines, -65 lines 0 comments Download
D gpu/include/GrConfig.h View 1 chunk +0 lines, -438 lines 0 comments Download
D gpu/include/GrContext.h View 1 chunk +0 lines, -733 lines 0 comments Download
D gpu/include/GrFontScaler.h View 1 chunk +0 lines, -37 lines 0 comments Download
D gpu/include/GrGLConfig.h View 1 chunk +0 lines, -265 lines 0 comments Download
D gpu/include/GrGLConfig_chrome.h View 1 chunk +0 lines, -27 lines 0 comments Download
D gpu/include/GrGLDefines.h View 1 chunk +0 lines, -659 lines 0 comments Download
D gpu/include/GrGLInterface.h View 1 chunk +0 lines, -414 lines 0 comments Download
D gpu/include/GrGlyph.h View 1 chunk +0 lines, -82 lines 0 comments Download
D gpu/include/GrGpuVertex.h View 1 chunk +0 lines, -97 lines 0 comments Download
D gpu/include/GrIPoint.h View 1 chunk +0 lines, -28 lines 0 comments Download
D gpu/include/GrInstanceCounter.h View 1 chunk +0 lines, -40 lines 0 comments Download
D gpu/include/GrKey.h View 1 chunk +0 lines, -40 lines 0 comments Download
D gpu/include/GrMatrix.h View 1 chunk +0 lines, -19 lines 0 comments Download
D gpu/include/GrMesh.h View 1 chunk +0 lines, -49 lines 0 comments Download
D gpu/include/GrNoncopyable.h View 1 chunk +0 lines, -31 lines 0 comments Download
D gpu/include/GrPaint.h View 1 chunk +0 lines, -254 lines 0 comments Download
D gpu/include/GrPath.h View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/include/GrPathSink.h View 1 chunk +0 lines, -29 lines 0 comments Download
D gpu/include/GrPlotMgr.h View 1 chunk +0 lines, -77 lines 0 comments Download
D gpu/include/GrPoint.h View 1 chunk +0 lines, -31 lines 0 comments Download
D gpu/include/GrRandom.h View 1 chunk +0 lines, -55 lines 0 comments Download
D gpu/include/GrRect.h View 1 chunk +0 lines, -37 lines 0 comments Download
D gpu/include/GrRectanizer.h View 1 chunk +0 lines, -57 lines 0 comments Download
D gpu/include/GrRefCnt.h View 1 chunk +0 lines, -34 lines 0 comments Download
D gpu/include/GrRenderTarget.h View 1 chunk +0 lines, -209 lines 0 comments Download
D gpu/include/GrResource.h View 1 chunk +0 lines, -78 lines 0 comments Download
D gpu/include/GrSamplerState.h View 1 chunk +0 lines, -265 lines 0 comments Download
D gpu/include/GrScalar.h View 1 chunk +0 lines, -49 lines 0 comments Download
D gpu/include/GrStencil.h View 1 chunk +0 lines, -211 lines 0 comments Download
D gpu/include/GrStopwatch.h View 1 chunk +0 lines, -128 lines 0 comments Download
D gpu/include/GrStringBuilder.h View 1 chunk +0 lines, -19 lines 0 comments Download
D gpu/include/GrTBSearch.h View 1 chunk +0 lines, -46 lines 0 comments Download
D gpu/include/GrTDArray.h View 1 chunk +0 lines, -216 lines 0 comments Download
D gpu/include/GrTHashCache.h View 1 chunk +0 lines, -219 lines 0 comments Download
D gpu/include/GrTLList.h View 1 chunk +0 lines, -54 lines 0 comments Download
D gpu/include/GrTemplates.h View 1 chunk +0 lines, -69 lines 0 comments Download
D gpu/include/GrTextContext.h View 1 chunk +0 lines, -68 lines 0 comments Download
D gpu/include/GrTextStrike.h View 1 chunk +0 lines, -115 lines 0 comments Download
D gpu/include/GrTexture.h View 1 chunk +0 lines, -183 lines 0 comments Download
D gpu/include/GrTypes.h View 1 chunk +0 lines, -637 lines 0 comments Download
D gpu/include/GrUserConfig.h View 1 chunk +0 lines, -83 lines 0 comments Download
D gpu/include/SkUIView.h View 1 chunk +0 lines, -65 lines 0 comments Download
D gpu/src/FlingState.cpp View 1 chunk +0 lines, -127 lines 0 comments Download
D gpu/src/GrAAHairLinePathRenderer.h View 1 chunk +0 lines, -61 lines 0 comments Download
D gpu/src/GrAAHairLinePathRenderer.cpp View 1 chunk +0 lines, -732 lines 0 comments Download
D gpu/src/GrAddPathRenderers_aahairline.cpp View 1 chunk +0 lines, -20 lines 0 comments Download
D gpu/src/GrAddPathRenderers_none.cpp View 1 chunk +0 lines, -15 lines 0 comments Download
D gpu/src/GrAddPathRenderers_tesselated.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
D gpu/src/GrAllocPool.cpp View 1 chunk +0 lines, -120 lines 0 comments Download
D gpu/src/GrAtlas.cpp View 1 chunk +0 lines, -200 lines 0 comments Download
D gpu/src/GrBinHashKey.h View 1 chunk +0 lines, -94 lines 0 comments Download
D gpu/src/GrBufferAllocPool.h View 1 chunk +0 lines, -350 lines 0 comments Download
D gpu/src/GrBufferAllocPool.cpp View 1 chunk +0 lines, -459 lines 0 comments Download
D gpu/src/GrClip.cpp View 1 chunk +0 lines, -145 lines 0 comments Download
D gpu/src/GrContext.cpp View 1 chunk +0 lines, -1930 lines 0 comments Download
D gpu/src/GrDefaultPathRenderer.h View 1 chunk +0 lines, -59 lines 0 comments Download
D gpu/src/GrDefaultPathRenderer.cpp View 1 chunk +0 lines, -560 lines 0 comments Download
D gpu/src/GrDrawMesh.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
D gpu/src/GrDrawTarget.h View 1 chunk +0 lines, -1476 lines 0 comments Download
D gpu/src/GrDrawTarget.cpp View 1 chunk +0 lines, -1262 lines 0 comments Download
D gpu/src/GrGLDefaultInterface_none.cpp View 1 chunk +0 lines, -13 lines 0 comments Download
D gpu/src/GrGLIRect.h View 1 chunk +0 lines, -74 lines 0 comments Download
D gpu/src/GrGLIndexBuffer.h View 1 chunk +0 lines, -55 lines 0 comments Download
D gpu/src/GrGLIndexBuffer.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
D gpu/src/GrGLInterface.cpp View 1 chunk +0 lines, -495 lines 0 comments Download
D gpu/src/GrGLProgram.h View 1 chunk +0 lines, -347 lines 0 comments Download
D gpu/src/GrGLProgram.cpp View 1 chunk +0 lines, -1623 lines 0 comments Download
D gpu/src/GrGLRenderTarget.h View 1 chunk +0 lines, -108 lines 0 comments Download
D gpu/src/GrGLRenderTarget.cpp View 1 chunk +0 lines, -96 lines 0 comments Download
D gpu/src/GrGLShaderVar.h View 1 chunk +0 lines, -217 lines 0 comments Download
D gpu/src/GrGLStencilBuffer.h View 1 chunk +0 lines, -60 lines 0 comments Download
D gpu/src/GrGLStencilBuffer.cpp View 1 chunk +0 lines, -40 lines 0 comments Download
D gpu/src/GrGLTexture.h View 1 chunk +0 lines, -154 lines 0 comments Download
D gpu/src/GrGLTexture.cpp View 1 chunk +0 lines, -187 lines 0 comments Download
D gpu/src/GrGLUtil.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
D gpu/src/GrGLVertexBuffer.h View 1 chunk +0 lines, -52 lines 0 comments Download
D gpu/src/GrGLVertexBuffer.cpp View 1 chunk +0 lines, -126 lines 0 comments Download
D gpu/src/GrGeometryBuffer.h View 1 chunk +0 lines, -90 lines 0 comments Download
D gpu/src/GrGpu.h View 1 chunk +0 lines, -423 lines 0 comments Download
D gpu/src/GrGpu.cpp View 1 chunk +0 lines, -937 lines 0 comments Download
D gpu/src/GrGpuFactory.cpp View 1 chunk +0 lines, -69 lines 0 comments Download
D gpu/src/GrGpuGL.h View 1 chunk +0 lines, -264 lines 0 comments Download
D gpu/src/GrGpuGL.cpp View 1 chunk +0 lines, -2260 lines 0 comments Download
D gpu/src/GrGpuGLFixed.h View 1 chunk +0 lines, -65 lines 0 comments Download
D gpu/src/GrGpuGLFixed.cpp View 1 chunk +0 lines, -382 lines 0 comments Download
D gpu/src/GrGpuGLShaders.h View 1 chunk +0 lines, -93 lines 0 comments Download
D gpu/src/GrGpuGLShaders.cpp View 1 chunk +0 lines, -1059 lines 0 comments Download
D gpu/src/GrInOrderDrawBuffer.h View 1 chunk +0 lines, -188 lines 0 comments Download
D gpu/src/GrInOrderDrawBuffer.cpp View 1 chunk +0 lines, -618 lines 0 comments Download
D gpu/src/GrIndexBuffer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D gpu/src/GrMatrix.cpp View 1 chunk +0 lines, -713 lines 0 comments Download
D gpu/src/GrMemory.cpp View 1 chunk +0 lines, -27 lines 0 comments Download
D gpu/src/GrPathRenderer.h View 1 chunk +0 lines, -229 lines 0 comments Download
D gpu/src/GrPathRenderer.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D gpu/src/GrPathRendererChain.h View 1 chunk +0 lines, -63 lines 0 comments Download
D gpu/src/GrPathRendererChain.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
D gpu/src/GrPathUtils.h View 1 chunk +0 lines, -50 lines 0 comments Download
D gpu/src/GrPathUtils.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
D gpu/src/GrPrintf_printf.cpp View 1 chunk +0 lines, -29 lines 0 comments Download
D gpu/src/GrRectanizer.cpp View 1 chunk +0 lines, -123 lines 0 comments Download
D gpu/src/GrRectanizer_fifo.cpp View 1 chunk +0 lines, -123 lines 0 comments Download
D gpu/src/GrRedBlackTree.h View 1 chunk +0 lines, -1118 lines 0 comments Download
D gpu/src/GrRenderTarget.cpp View 1 chunk +0 lines, -75 lines 0 comments Download
D gpu/src/GrResource.cpp View 1 chunk +0 lines, -34 lines 0 comments Download
D gpu/src/GrResourceCache.h View 1 chunk +0 lines, -312 lines 0 comments Download
D gpu/src/GrResourceCache.cpp View 1 chunk +0 lines, -376 lines 0 comments Download
D gpu/src/GrStencil.cpp View 1 chunk +0 lines, -376 lines 0 comments Download
D gpu/src/GrStencilBuffer.h View 1 chunk +0 lines, -106 lines 0 comments Download
D gpu/src/GrStencilBuffer.cpp View 1 chunk +0 lines, -55 lines 0 comments Download
D gpu/src/GrTesselatedPathRenderer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D gpu/src/GrTesselatedPathRenderer.cpp View 1 chunk +0 lines, -607 lines 0 comments Download
D gpu/src/GrTextContext.cpp View 1 chunk +0 lines, -314 lines 0 comments Download
D gpu/src/GrTextStrike.cpp View 1 chunk +0 lines, -205 lines 0 comments Download
D gpu/src/GrTextStrike_impl.h View 1 chunk +0 lines, -106 lines 0 comments Download
D gpu/src/GrTexture.cpp View 1 chunk +0 lines, -41 lines 0 comments Download
D gpu/src/GrVertexBuffer.h View 1 chunk +0 lines, -24 lines 0 comments Download
D gpu/src/android/GrGLDefaultInterface_android.cpp View 1 chunk +0 lines, -120 lines 0 comments Download
D gpu/src/app-android.cpp View 1 chunk +0 lines, -394 lines 0 comments Download
D gpu/src/gr_hello_world.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
D gpu/src/gr_unittests.cpp View 1 chunk +0 lines, -231 lines 0 comments Download
D gpu/src/ios/GrGLDefaultInterface_iOS.cpp View 1 chunk +0 lines, -152 lines 0 comments Download
D gpu/src/ios/SkUIView.mm View 1 chunk +0 lines, -827 lines 0 comments Download
D gpu/src/mac/GrGLDefaultInterface_mac.cpp View 1 chunk +0 lines, -170 lines 0 comments Download
D gpu/src/mesa/GrGLDefaultInterface_mesa.cpp View 1 chunk +0 lines, -188 lines 0 comments Download
D gpu/src/unix/GrGLDefaultInterface_unix.cpp View 1 chunk +0 lines, -191 lines 0 comments Download
D gpu/src/win/GrGLDefaultInterface_win.cpp View 1 chunk +0 lines, -197 lines 0 comments Download
M gyp/SampleApp.gyp View 1 chunk +1 line, -1 line 1 comment Download
M gyp/gpu.gyp View 6 chunks +127 lines, -128 lines 0 comments Download
M gyp/iOSSampleApp.gyp View 2 chunks +2 lines, -2 lines 1 comment Download
M gyp/tests.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
bsalomon
13 years, 1 month ago (2011-10-12 18:26:37 UTC) #1
bsalomon
The patchset shows up as a bunch of deletes, but its really a move of ...
13 years, 1 month ago (2011-10-12 18:49:07 UTC) #2
epoger
13 years, 1 month ago (2011-10-12 19:15:22 UTC) #3 
LGTM

http://codereview.appspot.com/5250070/diff/1/gyp/SampleApp.gyp
File gyp/SampleApp.gyp (right):

http://codereview.appspot.com/5250070/diff/1/gyp/SampleApp.gyp#newcode252
gyp/SampleApp.gyp:252: '../../include/gpu',
Why is this include dir at a different depth than the other one?  It looks to me
like the depth on this one is wrong... but it's no more wrong than it was
before, so I guess you should leave it as is.

http://codereview.appspot.com/5250070/diff/1/gyp/iOSSampleApp.gyp
File gyp/iOSSampleApp.gyp (right):

http://codereview.appspot.com/5250070/diff/1/gyp/iOSSampleApp.gyp#newcode249
gyp/iOSSampleApp.gyp:249: '../../include/gpu',
ditto
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b