Issue 5250067: Fix per-vertex coverage on Macs with aligned attrib bug

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5250067: Fix per-vertex coverage on Macs with aligned attrib bug (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 12 months ago by bsalomon

Modified:
12 years, 12 months ago

Reviewers:
TomH

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 12 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -7 lines)			Patch
M	gpu/src/GrContext.cpp	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	gpu/src/GrDrawTarget.h	View	1 chunk	+8 lines, -2 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders.cpp	View	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

On some Macs there is an AMD driver bug that requires each vertex attribute to ...

12 years, 12 months ago (2011-10-11 19:43:23 UTC) #1

TomH

LGTM http://codereview.appspot.com/5250067/diff/1/gpu/src/GrContext.cpp File gpu/src/GrContext.cpp (right): http://codereview.appspot.com/5250067/diff/1/gpu/src/GrContext.cpp#newcode1062 gpu/src/GrContext.cpp:1062: innerColor = 0xffffffff; I assume we don't need ...

12 years, 12 months ago (2011-10-11 20:05:54 UTC) #2

Closed with r2458

Expand All Messages | Collapse All Messages