Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(489)

Issue 5246061: Avoid iterating over unused samplers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by John Bauman
Modified:
13 years, 10 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Avoid iterating over unused samplers. Keep track of the maximum used sampler to avoid expensive iterations in applyTextures and validateSamplers. BUG= TEST=webgl conformance tests Committed: http://code.google.com/p/angleproject/source/detail?r=795

Patch Set 1 #

Patch Set 2 : rename to getUsedSamplerRange #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -3 lines) Patch
M src/libGLESv2/Context.cpp View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/libGLESv2/Program.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M src/libGLESv2/Program.cpp View 1 6 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 6
John Bauman
13 years, 10 months ago (2011-10-12 23:15:06 UTC) #1
nicolas
Looks generally ok but it's slightly confusing that getMaxUsedSampler actually returns the maximum used sampler ...
13 years, 10 months ago (2011-10-17 15:13:04 UTC) #2
nicolas
Actually getUsedSamplerCount wouldn't be right either. getUsedSamplerRange perhaps?
13 years, 10 months ago (2011-10-17 16:23:47 UTC) #3
John Bauman
On 2011/10/17 16:23:47, nicolas wrote: > Actually getUsedSamplerCount wouldn't be right either. getUsedSamplerRange > perhaps? ...
13 years, 10 months ago (2011-10-17 21:32:00 UTC) #4
John Bauman
On 2011/10/17 21:32:00, John Bauman wrote: > On 2011/10/17 16:23:47, nicolas wrote: > > Actually ...
13 years, 10 months ago (2011-10-17 23:59:40 UTC) #5
nicolas
13 years, 10 months ago (2011-10-18 17:19:19 UTC) #6
Looks good to me.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b