Issue 5244045: Makeify the website build.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5244045: Makeify the website build. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Julien Rioux

Modified:
13 years, 4 months ago

Reviewers:
Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Makeify the website build. Properly track dependencies, allow for parallel build, and rebuild only what needs to be updated.

Patch Set 1 #

Total comments: 2

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -94 lines)			Patch
	M	make/website.make	View		2 chunks	+166 lines, -94 lines	2 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Graham Percival (old account)

13 years, 7 months ago (2011-10-09 16:03:08 UTC) #1

LGTM, thanks so much for cleaning this up!

http://codereview.appspot.com/5244045/diff/1/make/website.make
File make/website.make (right):

http://codereview.appspot.com/5244045/diff/1/make/website.make#newcode73
make/website.make:73: CREATE_VERSION=python
$(script-dir)/create-version-itexi.py
whoops, we're inconsistent in whether we use python or $(PYTHON).  Let's leave
it there for now, but it's something for future consideration

http://codereview.appspot.com/5244045/diff/1/make/website.make#newcode106
make/website.make:106: bib-files = $(OUT)/others-did.itexi $(OUT)/we-wrote.itexi
we'll be able to remove the bib stuff once the dev/website-build material has
been added.  I'll have to re-do that stuff, but it'll be easy with the new
website.make.

Expand All Messages | Collapse All Messages