Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(497)

Issue 5242056: move utils/SkEGLContext to gpu/SkGLContext, some gpu.gyp cleanup (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 12 months ago by bsalomon
Modified:
12 years, 12 months ago
Reviewers:
bungeman, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -950 lines) Patch
M bench/benchmain.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gm/gmmain.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M gyp/gpu.gyp View 6 chunks +95 lines, -86 lines 0 comments Download
M gyp/utils.gyp View 7 chunks +0 lines, -21 lines 0 comments Download
M include/gpu/GrResource.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/gpu/SkGLContext.h View 1 2 chunks +5 lines, -5 lines 0 comments Download
D include/utils/SkEGLContext.h View 1 1 chunk +0 lines, -58 lines 0 comments Download
M src/gpu/GrBinHashKey.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrGLProgram.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrGLProgram.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrGpuGLShaders.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrGpuGLShaders.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/GrResource.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/SkGLContext_none.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/android/GrGLDefaultInterface_android.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/ios/GrGLDefaultInterface_iOS.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/gpu/ios/SkUIView.mm View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/mac/SkGLContext_mac.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/gpu/mesa/GrGLDefaultInterface_mesa.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/mesa/SkGLContext_mesa.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/unix/GrGLDefaultInterface_unix.cpp View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/gpu/unix/SkGLContext_unix.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
A + src/gpu/win/SkGLContext_win.cpp View 1 4 chunks +53 lines, -53 lines 0 comments Download
D src/utils/SkEGLContext_none.cpp View 1 chunk +0 lines, -19 lines 0 comments Download
D src/utils/mac/SkEGLContext_mac.cpp View 1 chunk +0 lines, -77 lines 0 comments Download
D src/utils/mesa/SkEGLContext_Mesa.cpp View 1 chunk +0 lines, -137 lines 0 comments Download
D src/utils/unix/SkEGLContext_Unix.cpp View 1 chunk +0 lines, -275 lines 0 comments Download
D src/utils/win/SkEGLContext_Win.cpp View 1 chunk +0 lines, -202 lines 0 comments Download
M tests/Test.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/Test.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3
bsalomon
This diff looks way bigger than it is. Here's what it does: 1) Some cleanup ...
12 years, 12 months ago (2011-10-12 21:13:14 UTC) #1
bsalomon
Got a verbal LGTM from reed@
12 years, 12 months ago (2011-10-13 13:33:39 UTC) #2
bsalomon
12 years, 12 months ago (2011-10-13 13:33:53 UTC) #3
On 2011/10/13 13:33:39, bsalomon wrote:
> Got a verbal LGTM from reed@

Closed with r2474.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b