Issue 5242041: Allows NoteColumns to be skipped over by glissandi.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5242041: Allows NoteColumns to be skipped over by glissandi. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by MikeSol

Modified:
12 years, 5 months ago

Reviewers:
pkx166h, mike

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Allows NoteColumns to be skipped over by glissandi.

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -0 lines)			Patch
A	input/regression/glissando-skip.ly	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	lily/glissando-engraver.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lily/rhythmic-head.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

pkx166h

passes make and make check only throws out @@ -14,9 +14,9 @@ Writing graph `#f'...digraph ...

12 years, 6 months ago (2011-10-08 05:26:58 UTC) #1

mike_apollinemike.com

12 years, 6 months ago (2011-10-08 09:06:03 UTC) #2

On Oct 8, 2011, at 7:26 AM, pkx166h@gmail.com wrote:

> passes make and make check only throws out
> 
> @@ -14,9 +14,9 @@
> Writing graph `#f'...digraph G {
> rankdir="LR"
> node [shape=rectangle]
> -41 [label="caching Stem.stencil\n# -> #"]
> +41 [label="caching LedgerLineSpanner.stencil\n# -> #"]
> 40 [label="caching VerticalAxisGroup.stencil\n# -> #f"]
> -39 [label="caching LedgerLineSpanner.stencil\n# -> #"]
> +39 [label="caching Stem.stencil\n# -> #"]
> 38 [label="caching StaffSymbol.stencil\n# -> #"]
> 37 [label="caching Stem.Y-extent\n# -> (-2.812186 . 0.5)"]
> 36 [label="caching Stem.length\n# -> 6.624372"]
> @@ -56,7 +56,7 @@
> 2 [label="NoteHead\n/home/jlowe/lilypond-git/lily/engraver.cc:60\ncause
> <- # 41
> +37 -> 39
> 36 -> 37
> 35 -> 36
> 34 -> 35
> 
> --snip--
> 
> James
> 

I swear that I didn't see this sorta thing before I pushed my first "cosmetic"
patch - graphviz seems to be going berzerk now.  Are people sure that this sorta
thing happens often?

Cheers,
MS

Expand All Messages | Collapse All Messages