Issue 5241048: Navmesh (don't impliment as a modifier)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5241048: Navmesh (don't impliment as a modifier)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by ideasman42

Modified:
13 years, 1 month ago

Reviewers:
nazgul

Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/

Visibility:
Public.

Patch Set 1 #

Total comments: 5

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+225 lines, -346 lines)			Patch
M	release/scripts/startup/bl_ui/properties_data_modifier.py	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	release/scripts/startup/bl_ui/properties_game.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	source/blender/blenkernel/BKE_mesh.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	source/blender/blenkernel/CMakeLists.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	source/blender/blenkernel/intern/DerivedMesh.c	View	4 chunks	+185 lines, -0 lines	0 comments	Download
M	source/blender/blenkernel/intern/mesh.c	View	1 chunk	+25 lines, -0 lines	2 comments	Download
M	source/blender/editors/mesh/mesh_navmesh.c	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	source/blender/makesdna/DNA_modifier_types.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	source/blender/makesrna/intern/rna_modifier.c	View	4 chunks	+0 lines, -15 lines	0 comments	Download
M	source/blender/makesrna/intern/rna_object.c	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	source/blender/modifiers/CMakeLists.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	source/blender/modifiers/intern/MOD_navmesh.c	View	1 chunk	+0 lines, -313 lines	0 comments	Download
M	source/blender/modifiers/intern/MOD_util.c	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	source/creator/CMakeLists.txt	View	2 chunks	+2 lines, -0 lines	3 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

nazgul

Hi, Just few minor questions in comments. http://codereview.appspot.com/5241048/diff/1/source/blender/blenkernel/intern/mesh.c File source/blender/blenkernel/intern/mesh.c (right): http://codereview.appspot.com/5241048/diff/1/source/blender/blenkernel/intern/mesh.c#newcode1619 source/blender/blenkernel/intern/mesh.c:1619: // ob->body_type ...

13 years, 1 month ago (2011-10-09 11:59:14 UTC) #1

ideasman42

13 years, 1 month ago (2011-10-09 12:04:05 UTC) #2

2 errors noticed by Sergy, replied to say Ill address before commit.

http://codereview.appspot.com/5241048/diff/1/source/blender/blenkernel/intern...
File source/blender/blenkernel/intern/mesh.c (right):

http://codereview.appspot.com/5241048/diff/1/source/blender/blenkernel/intern...
source/blender/blenkernel/intern/mesh.c:1619: //		ob->body_type =
OB_BODY_TYPE_NAVMESH;
On 2011/10/09 11:59:14, nazgul wrote:
> Looks quite unfinished from logic point of view.

These will be removed before commit, this was from the modifier code (modifier
editing object flags is silly btw). This is set when setting the physics type
anyway.

http://codereview.appspot.com/5241048/diff/1/source/creator/CMakeLists.txt
File source/creator/CMakeLists.txt (right):

http://codereview.appspot.com/5241048/diff/1/source/creator/CMakeLists.txt#ne...
source/creator/CMakeLists.txt:863: bf_blenkernel
On 2011/10/09 11:59:14, nazgul wrote:
> Is it a lag of codereview or indentation is really missed?

Ack. was giving linking issue so quickly added these, also will correct before
committing.

Expand All Messages | Collapse All Messages