Issue 5241047: Fix 1377: looser spacing for ragged-last-bottom.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5241047: Fix 1377: looser spacing for ragged-last-bottom. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 6 months ago by joeneeman

Modified:
12 years, 3 months ago

Reviewers:
Keith, janek

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix 1377: looser spacing for ragged-last-bottom. Under ragged-last-bottom, try to make the last page match the previous page by using the same for for spacing it. Previously, the last page was never stretched at all, which meant that it always looked tighter than the previous page.

Patch Set 1 #

Created: 12 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -6 lines)			Patch
M	lily/include/page-layout-problem.hh	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	lily/include/simple-spacer.hh	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	lily/page-breaking.cc	View	3 chunks	+17 lines, -2 lines	0 comments	Download
M	lily/page-layout-problem.cc	View	4 chunks	+36 lines, -3 lines	0 comments	Download
M	lily/simple-spacer.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Keith

LGTM and makes just about every output score look much better.

12 years, 6 months ago (2011-10-25 05:11:14 UTC) #1

janek

12 years, 3 months ago (2011-12-26 09:09:52 UTC) #2

On 2011/10/25 05:11:14, Keith wrote:
> LGTM and makes just about every output score look much better.

Wow, this is great!
Should this Rietveld issue be closed?  I see that
http://code.google.com/p/lilypond/issues/detail?id=1377 has Fixed status,
however no commit ID is mentioned...

Expand All Messages | Collapse All Messages