Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 5240052: The feed_info.txt proposal has been officially adopted (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 4 months ago by bdferris1
Modified:
14 years, 4 months ago
Reviewers:
neun
Base URL:
http://googletransitdatafeed.googlecode.com/svn/trunk/
Visibility:
Public.

Description

See discussion here: http://code.google.com/p/googletransitdatafeed/issues/detail?id=303 This patch does the main work of moving feed_info.txt support out of the custom Google extension and into the main transitfeed module.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Addressing previous comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -540 lines) Patch
python/extensions/googletransit/README View 2 chunks +0 lines, -21 lines 0 comments Download
python/extensions/googletransit/__init__.py View 1 1 chunk +0 lines, -2 lines 0 comments Download
python/extensions/googletransit/feedinfo.py View 1 chunk +0 lines, -88 lines 0 comments Download
python/extensions/googletransit/schedule.py View 1 chunk +0 lines, -130 lines 0 comments Download
python/extensions/googletransit/setup_extension.py View 1 2 chunks +0 lines, -11 lines 0 comments Download
python/test/testgoogletransitextension.py View 1 chunk +0 lines, -258 lines 0 comments Download
python/test/testtransitfeed.py View 1 3 chunks +281 lines, -0 lines 0 comments Download
python/transitfeed/feedinfo.py View 3 chunks +16 lines, -29 lines 0 comments Download
python/transitfeed/gtfsfactory.py View 3 chunks +5 lines, -0 lines 0 comments Download
python/transitfeed/schedule.py View 6 chunks +50 lines, -1 line 0 comments Download

Messages

Total messages: 5
bdferris1
14 years, 4 months ago (2011-10-10 12:16:31 UTC) #1
neun
just some comments http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/__init__.py File python/extensions/googletransit/__init__.py (right): http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/__init__.py#newcode20 python/extensions/googletransit/__init__.py:20: from schedule import * didn't you ...
14 years, 4 months ago (2011-10-10 16:03:57 UTC) #2
bdferris1
Addressing previous comments.
14 years, 4 months ago (2011-10-10 16:10:39 UTC) #3
bdferris1
http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/__init__.py File python/extensions/googletransit/__init__.py (right): http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/__init__.py#newcode20 python/extensions/googletransit/__init__.py:20: from schedule import * On 2011/10/10 16:03:57, neun wrote: ...
14 years, 4 months ago (2011-10-10 16:10:54 UTC) #4
neun
14 years, 4 months ago (2011-10-13 08:52:57 UTC) #5
LGTM

sorry for the delay!

On 2011/10/10 16:10:54, bdferris1 wrote:
>
http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/...
> File python/extensions/googletransit/__init__.py (right):
> 
>
http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/...
> python/extensions/googletransit/__init__.py:20: from schedule import *
> On 2011/10/10 16:03:57, neun wrote:
> > didn't you remove schedule as well?
> 
> Done.
> 
>
http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/...
> File python/extensions/googletransit/setup_extension.py (right):
> 
>
http://codereview.appspot.com/5240052/diff/1/python/extensions/googletransit/...
> python/extensions/googletransit/setup_extension.py:22: import schedule
> On 2011/10/10 16:03:57, neun wrote:
> > didn't you remove schedule as well?
> 
> Done.
> 
> http://codereview.appspot.com/5240052/diff/1/python/test/testtransitfeed.py
> File python/test/testtransitfeed.py (right):
> 
>
http://codereview.appspot.com/5240052/diff/1/python/test/testtransitfeed.py#n...
> python/test/testtransitfeed.py:6393: class
> FeedInfoExtensionTestCase(util.MemoryZipTestCase):
> On 2011/10/10 16:03:57, neun wrote:
> > it's not an extension anymore! Please rename.
> 
> Done.
> 
>
http://codereview.appspot.com/5240052/diff/1/python/test/testtransitfeed.py#n...
> python/test/testtransitfeed.py:6396: super(FeedInfoExtensionTestCase,
> self).setUp()
> On 2011/10/10 16:03:57, neun wrote:
> > dito
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b