Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(87)

Issue 5229056: Avoid unnecessarily copying uniforms (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 10 months ago by John Bauman
Modified:
13 years, 10 months ago
Reviewers:
dgkoch, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Avoid unnecessarily copying uniforms Transpose and expand matrices and float vectors when copied on setUniform (and getUniform) to avoid allocating an array and doing that on applyUniform. Then use straight D3D calls, not D3DX, to possibly avoid another copy. Gets NaCl donuts test from 19->25 fps. BUG= TEST=webgl conformance tests Committed: http://code.google.com/p/angleproject/source/detail?r=800

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use raw d3d9 for everything #

Patch Set 3 : make certain bools work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -449 lines) Patch
M src/libGLESv2/Program.h View 1 2 2 chunks +13 lines, -15 lines 0 comments Download
M src/libGLESv2/Program.cpp View 1 2 19 chunks +277 lines, -432 lines 0 comments Download
M src/libGLESv2/utilities.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/libGLESv2/utilities.cpp View 1 2 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 7
John Bauman
13 years, 10 months ago (2011-10-12 19:32:51 UTC) #1
nicolas
http://codereview.appspot.com/5229056/diff/1/src/libGLESv2/Program.h File src/libGLESv2/Program.h (right): http://codereview.appspot.com/5229056/diff/1/src/libGLESv2/Program.h#newcode50 src/libGLESv2/Program.h:50: int psCount; Do we really still need vsHandle and ...
13 years, 10 months ago (2011-10-12 21:08:58 UTC) #2
John Bauman
On 2011/10/12 21:08:58, nicolas wrote: > http://codereview.appspot.com/5229056/diff/1/src/libGLESv2/Program.h > File src/libGLESv2/Program.h (right): > > http://codereview.appspot.com/5229056/diff/1/src/libGLESv2/Program.h#newcode50 > ...
13 years, 10 months ago (2011-10-12 21:12:00 UTC) #3
nicolas
On 2011/10/12 21:12:00, John Bauman wrote: > There we some more complex cases that I ...
13 years, 10 months ago (2011-10-13 14:22:37 UTC) #4
dgkoch
On 2011/10/13 14:22:37, nicolas wrote: > On 2011/10/12 21:12:00, John Bauman wrote: > > There ...
13 years, 10 months ago (2011-10-13 15:22:28 UTC) #5
John Bauman
On 2011/10/13 15:22:28, dgkoch wrote: > On 2011/10/13 14:22:37, nicolas wrote: > > On 2011/10/12 ...
13 years, 10 months ago (2011-10-14 03:49:42 UTC) #6
nicolas
13 years, 10 months ago (2011-10-19 14:33:47 UTC) #7
On 2011/10/14 03:49:42, John Bauman wrote:
> Ok, I've converted everything over.

Thanks, looks good to me. Please test thoroughly.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b