Issue 5216044: Sync to head of httplib2.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5216044: Sync to head of httplib2. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by jcgregorio_google

Modified:
12 years, 11 months ago

Reviewers:
aiuto

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+141 lines, -3 lines)			Patch
M	httplib2/__init__.py	View	4 chunks	+6 lines, -2 lines	0 comments	Download
M	httplib2/cacerts.txt	View	1 chunk	+81 lines, -0 lines	0 comments	Download
M	httplib2/socks.py	View	6 chunks	+54 lines, -1 line	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

aiuto

12 years, 11 months ago (2011-10-07 03:10:57 UTC) #2

LGTM.

Ignore the comments. I only now realize that you are pulling in someone else's
code,

http://codereview.appspot.com/5216044/diff/1/httplib2/socks.py
File httplib2/socks.py (right):

http://codereview.appspot.com/5216044/diff/1/httplib2/socks.py#newcode170
httplib2/socks.py:170: if (self.__proxy[4] != None and self.__proxy[5] != None):
Oh. so horrible. The self.__proxy[N] with no explanation of the parts.
The   if X != None.

But.. This is consistent with the original style, so I guess it's the best
choice.

http://codereview.appspot.com/5216044/diff/1/httplib2/socks.py#newcode368
httplib2/socks.py:368: headers += ["Host: ", destaddr, "\r\n"]
Can't you write
   headers = [... ... ..
                     "host', ....]
rather than the +=?

Expand All Messages | Collapse All Messages