Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(56)

Issue 52066: Implement a way for sk_malloc() to indicate when skia will safely handle NULL malloc()'s

Can't Edit
Can't Publish+Mail
Start Review
Created:
17 years, 1 month ago by Stephen White
Modified:
17 years, 1 month ago
Reviewers:
reed
Base URL:
http://skia.googlecode.com/svn/trunk/trunk/
Visibility:
Public.

Description

The malloc() in Chromium will intentionally trigger a __debugbreak (crash) whenever a NULL malloc() occurs. This is problematic in a number of places (eg., large <canvas> tag), where skia would otherwise gracefully handle the failure. This patch implements a function to know when skia will safely handle a NULL malloc(). In particular, when sk_malloc_flags() is called SK_MALLOC_THROW not set.

Patch Set 1 #

Patch Set 2 : 2nd version using separate implementation of SkMemory #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -0 lines) Patch
C:/src/chromium1/src/third_party/skia/src/ports/SkMemory_new_handler.cpp View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 3
Stephen White
17 years, 1 month ago (2009-04-29 19:14:16 UTC) #1
Stephen White
2nd version using separate implementation of SkMemory
17 years, 1 month ago (2009-05-05 14:19:36 UTC) #2
reed
17 years, 1 month ago (2009-05-05 19:53:38 UTC) #3
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b