Issue 52058: HOP/FOF changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 52058: HOP/FOF changes

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by stephenskory

Modified:
1 year ago

Reviewers:
matthewturk

CC:
yt-dev_lists.spacepope.org

Base URL:
http://svn.enzotools.org/yt/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -126 lines)			Patch
M	yt/lagos/HaloFinding.py	View	2 chunks	+2 lines, -1 line	2 comments	Download
M	yt/lagos/fof/EnzoFOF.c	View	4 chunks	+11 lines, -11 lines	0 comments	Download
M	yt/lagos/fof/fof_main.c	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	yt/lagos/fof/kd.h	View	3 chunks	+29 lines, -29 lines	1 comment	Download
M	yt/lagos/fof/kd.c	View	17 chunks	+56 lines, -56 lines	0 comments	Download
M	yt/lagos/hop/hop_regroup.c	View	4 chunks	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

matthewturk

15 years, 6 months ago (2009-04-27 15:24:55 UTC) #1

This patch looks mostly alright to me -- thanks very much for getting rid of the
temporary file, and I agree that the FOF code should have a suffix to
distinguish it from HOP structures.  Here are some very minor comments...

http://codereview.appspot.com/52058/diff/1/2
File yt/lagos/HaloFinding.py (right):

http://codereview.appspot.com/52058/diff/1/2#newcode175
Line 175: _fields = ["particle_position_%s" % ax for ax in
'xyz',"particle_velocity_%s" % ax for ax in 'xyz']
This line is too long, split it to the next one.

http://codereview.appspot.com/52058/diff/1/2#newcode404
Line 404: self.data_source.get_data(["particle_velocity_%s" % ax for ax in
'xyz'])
This is redundant with the line above; additionally, we don't need
particle_velocity until the write_out.

http://codereview.appspot.com/52058/diff/1/5
File yt/lagos/fof/kd.h (right):

http://codereview.appspot.com/52058/diff/1/5#newcode38
Line 38: } KDFOFNFOF;
I think this should be KDNFOF; maybe the search-n-replace was done out of order?

Expand All Messages | Collapse All Messages