Issue 5193044: TOOLS: Change package to com.google.i18n.phonenumbers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5193044: TOOLS: Change package to com.google.i18n.phonenumbers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by philippe

Modified:
14 years, 1 month ago

Reviewers:
lararennie, Shaopeng

Base URL:
https://libphonenumber.googlecode.com/svn/trunk

Visibility:
Public.

Description

TOOLS: Change package to com.google.i18n.phonenumbers. Committed: http://code.google.com/p/libphonenumber/source/detail?r=371

Patch Set 1 #

Patch Set 2 : Update #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3703 lines)			Patch
M	javascript/README	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/common/src/com/google/i18n/phonenumbers/BuildMetadataFromXml.java	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/common/src/com/google/i18n/phonenumbers/Command.java	View		2 chunks	+2 lines, -2 lines	0 comments	Download
A +	tools/java/common/src/com/google/i18n/phonenumbers/CommandDispatcher.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/common/src/com/google/i18n/phonenumbers/CopyrightNotice.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/common/src/com/google/i18n/phonenumbers/FileUtils.java	View		1 chunk	+1 line, -1 line	0 comments	Download
D	tools/java/common/src/com/google/i18n/phonenumbers/tools/BuildMetadataFromXml.java	View	1	1 chunk	+0 lines, -451 lines	0 comments	Download
D	tools/java/common/src/com/google/i18n/phonenumbers/tools/Command.java	View		1 chunk	+0 lines, -51 lines	0 comments	Download
D	tools/java/common/src/com/google/i18n/phonenumbers/tools/CommandDispatcher.java	View		1 chunk	+0 lines, -78 lines	0 comments	Download
D	tools/java/common/src/com/google/i18n/phonenumbers/tools/CopyrightNotice.java	View		1 chunk	+0 lines, -66 lines	0 comments	Download
D	tools/java/common/src/com/google/i18n/phonenumbers/tools/FileUtils.java	View		1 chunk	+0 lines, -52 lines	0 comments	Download
A +	tools/java/common/test/com/google/i18n/phonenumbers/BuildMetadataFromXmlTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
D	tools/java/common/test/com/google/i18n/phonenumbers/tools/BuildMetadataFromXmlTest.java	View		1 chunk	+0 lines, -516 lines	0 comments	Download
M	tools/java/cpp-build/pom.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/cpp-build/src/com/google/i18n/phonenumbers/BuildMetadataCppFromXml.java	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	tools/java/cpp-build/src/com/google/i18n/phonenumbers/EntryPoint.java	View		1 chunk	+1 line, -1 line	0 comments	Download
D	tools/java/cpp-build/src/com/google/i18n/phonenumbers/tools/BuildMetadataCppFromXml.java	View		1 chunk	+0 lines, -254 lines	0 comments	Download
D	tools/java/cpp-build/src/com/google/i18n/phonenumbers/tools/EntryPoint.java	View		1 chunk	+0 lines, -33 lines	0 comments	Download
M	tools/java/cpp-build/target/cpp-build-1.0-SNAPSHOT-jar-with-dependencies.jar	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tools/java/cpp-build/test/com/google/i18n/phonenumbers/BuildMetadataCppFromXmlTest.java	View		1 chunk	+1 line, -1 line	0 comments	Download
D	tools/java/cpp-build/test/com/google/i18n/phonenumbers/tools/BuildMetadataCppFromXmlTest.java	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	tools/java/data/pom.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/data/src/com/google/i18n/phonenumbers/CombineGeoData.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/data/src/com/google/i18n/phonenumbers/CombineGeoDataServlet.java	View		1 chunk	+1 line, -1 line	0 comments	Download
D	tools/java/data/src/com/google/i18n/phonenumbers/tools/CombineGeoData.java	View		1 chunk	+0 lines, -287 lines	0 comments	Download
D	tools/java/data/src/com/google/i18n/phonenumbers/tools/CombineGeoDataServlet.java	View		1 chunk	+0 lines, -46 lines	0 comments	Download
A +	tools/java/data/test/com/google/i18n/phonenumbers/CombineGeoDataTest.java	View		1 chunk	+2 lines, -2 lines	0 comments	Download
D	tools/java/data/test/com/google/i18n/phonenumbers/tools/CombineGeoDataTest.java	View		1 chunk	+0 lines, -233 lines	0 comments	Download
M	tools/java/data/webapp/WEB-INF/web.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/java/java-build/pom.xml	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataJsonFromXml.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/java-build/src/com/google/i18n/phonenumbers/BuildMetadataProtoFromXml.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/java-build/src/com/google/i18n/phonenumbers/EntryPoint.java	View		1 chunk	+3 lines, -1 line	0 comments	Download
A +	tools/java/java-build/src/com/google/i18n/phonenumbers/JSArrayBuilder.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	tools/java/java-build/src/com/google/i18n/phonenumbers/geocoding/GenerateAreaCodeData.java	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
D	tools/java/java-build/src/com/google/i18n/phonenumbers/tools/BuildMetadataJsonFromXml.java	View		1 chunk	+0 lines, -359 lines	0 comments	Download
D	tools/java/java-build/src/com/google/i18n/phonenumbers/tools/BuildMetadataProtoFromXml.java	View		1 chunk	+0 lines, -192 lines	0 comments	Download
D	tools/java/java-build/src/com/google/i18n/phonenumbers/tools/EntryPoint.java	View		1 chunk	+0 lines, -35 lines	0 comments	Download
D	tools/java/java-build/src/com/google/i18n/phonenumbers/tools/GenerateAreaCodeData.java	View	1	1 chunk	+0 lines, -538 lines	0 comments	Download
D	tools/java/java-build/src/com/google/i18n/phonenumbers/tools/JSArrayBuilder.java	View		1 chunk	+0 lines, -135 lines	0 comments	Download
M	tools/java/java-build/target/java-build-1.0-SNAPSHOT-jar-with-dependencies.jar	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	tools/java/java-build/test/com/google/i18n/phonenumbers/geocoding/GenerateAreaCodeDataTest.java	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download
D	tools/java/java-build/test/com/google/i18n/phonenumbers/tools/GenerateAreaCodeDataTest.java	View	1	1 chunk	+0 lines, -292 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

philippe

On 2011/10/05 16:15:14, philippe wrote: I synchronized this CL with the latest push.

14 years, 2 months ago (2011-10-07 14:55:06 UTC) #2

LGTM

Expand All Messages | Collapse All Messages