Issue 5185047: Fixup empty path rendering in SkCanvas, add gm/sample

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5185047: Fixup empty path rendering in SkCanvas, add gm/sample (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by bsalomon

Modified:
12 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : update #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+299 lines, -7 lines)			Patch
A	gm/base-win/emptypath_4444.png	View		Binary file		0 comments	Download
A	gm/base-win/emptypath_565.png	View		Binary file		0 comments	Download
A	gm/base-win/emptypath_8888.png	View		Binary file		0 comments	Download
A	gm/base-win/emptypath_gpu.png	View		Binary file		0 comments	Download
A	gm/emptypath.cpp	View	1	1 chunk	+138 lines, -0 lines	0 comments	Download
M	gpu/include/GrTypes.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	gpu/src/GrContext.cpp	View		2 chunks	+11 lines, -1 line	0 comments	Download
M	gpu/src/GrGpu.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/src/GrTesselatedPathRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/SampleApp.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	gyp/gm.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkCanvas.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	samplecode/SampleEmptyPath.cpp	View		1 chunk	+130 lines, -0 lines	0 comments	Download
M	src/core/SkCanvas.cpp	View	1 2	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/5185047/diff/1/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): http://codereview.appspot.com/5185047/diff/1/src/core/SkCanvas.cpp#newcode1281 src/core/SkCanvas.cpp:1281: if (path.isInverseFillType() && 1. can't call a virtual like ...

12 years, 9 months ago (2011-10-05 19:44:06 UTC) #2

bsalomon

12 years, 9 months ago (2011-10-05 19:55:21 UTC) #3

Closed with r2414.

Expand All Messages | Collapse All Messages