Fix a few lilypond-book bugs on windows (Issue 1815).

Fix a few lilypond-book bugs on windows (Issue 1815).

  - book_snippets.py: Replace os.link (purely unix) when it is unavailable by shutil.copyfile.

  - lilylib.py: Windows command-line arguments don't need escaping.

  - lilypond-book.py: Use forward slashes within lilypond files.

[Reinhold, 2011-10-04 20:10:43]

http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py
File python/book_snippets.py (right):

http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py#newcode643
python/book_snippets.py:643: os.rename (src, dst)
Doesn't this REMOVE the src?
os.link creates a link at dst, so the files at src and dst are actually the same
file (i.e. both point to the same sectors on the hard drive, and thus they are
always identical, even if you change one).

http://codereview.appspot.com/5183042/diff/1/python/lilylib.py
File python/lilylib.py (right):

http://codereview.appspot.com/5183042/diff/1/python/lilylib.py#newcode154
python/lilylib.py:154: return x
Ah, so in windows you can give a command line argument argument of the form
  my-cmd  \$"`
and the command will actually receive a string containing
backslash-dollar-doublequote-backtick?
And none of these characters (dollar, double quotes, backtick, backslash) need
to be escaped with a backslash? i.e. you don't need
  my-cmd "\\\$\"\`"
?

[Julien Rioux, 2011-10-04 20:22:28]

Of course you know the code better, so please investigate. I did not understand
why we keep two points to the same file, but if it is needed, support for
windows will require copying the files. There are no hard links that I am aware
of.

http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py
File python/book_snippets.py (right):

http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py#newcode643
python/book_snippets.py:643: os.rename (src, dst)
On 2011/10/04 20:10:43, Reinhold wrote:
> Doesn't this REMOVE the src?
> os.link creates a link at dst, so the files at src and dst are actually the
same
> file (i.e. both point to the same sectors on the hard drive, and thus they are
> always identical, even if you change one). 
Yes it removes the src and moves it to dst. Why do you need the two points? When
I specify the output directory I expect the files to be moved there.

http://codereview.appspot.com/5183042/diff/1/python/lilylib.py
File python/lilylib.py (right):

http://codereview.appspot.com/5183042/diff/1/python/lilylib.py#newcode154
python/lilylib.py:154: return x
On 2011/10/04 20:10:43, Reinhold wrote:
> Ah, so in windows you can give a command line argument argument of the form
>   my-cmd  \$"`
> and the command will actually receive a string containing
> backslash-dollar-doublequote-backtick?
> And none of these characters (dollar, double quotes, backtick, backslash) need
> to be escaped with a backslash? i.e. you don't need
>   my-cmd "\\\$\"\`"
> ?

The " might give trouble, but it cannot appear in a filename. Same goes for \,
which is the path separator. It's definitely wrong to use \ as the escape
character anyway. The other characters are plain characters.

[circuitsoft.alex_gmail.com, 2011-10-05 03:17:18]

On Tue, Oct 4, 2011 at 3:22 PM, <julien.rioux@gmail.com> wrote:

>
> ... There are no hard links that I am aware of.
>
>
http://msdn.microsoft.com/en-us/library/windows/desktop/aa365006(v=vs.85).aspx

[Julien Rioux, 2011-10-05 14:17:29]

On Wed, Oct 5, 2011 at 5:17 AM, Alex Austin <circuitsoft.alex@gmail.com> wrote:
> On Tue, Oct 4, 2011 at 3:22 PM, <julien.rioux@gmail.com> wrote:
>>
>> ... There are no hard links that I am aware of.
>
> http://msdn.microsoft.com/en-us/library/windows/desktop/aa365006(v=vs.85).aspx

It is not a restriction of NTFS but of the windows C api and thus
indirectly a restriction for python on windows. Are you aware of some
python 2.4 code that implements it?

Regards,
Julien