Issue 5180047: Change SkAutoMaskImage so that we're less likely to write leaky code.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5180047: Change SkAutoMaskImage so that we're less likely to write leaky code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by bungeman

Modified:
13 years, 2 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 2 : SkAutoMaskFreeImage sounds good. #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -18 lines)			Patch
M	include/core/SkMaskFilter.h	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download
M	src/core/SkBitmap.cpp	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	src/core/SkDraw.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/core/SkMaskFilter.cpp	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

reed1

http://codereview.appspot.com/5180047/diff/1/include/core/SkMaskFilter.h File include/core/SkMaskFilter.h (left): http://codereview.appspot.com/5180047/diff/1/include/core/SkMaskFilter.h#oldcode99 include/core/SkMaskFilter.h:99: */ Perhaps this could be renamed now, to something ...

13 years, 2 months ago (2011-10-04 19:08:00 UTC) #2

bungeman

http://codereview.appspot.com/5180047/diff/1/include/core/SkMaskFilter.h File include/core/SkMaskFilter.h (left): http://codereview.appspot.com/5180047/diff/1/include/core/SkMaskFilter.h#oldcode99 include/core/SkMaskFilter.h:99: */ On 2011/10/04 19:08:00, reed1 wrote: > Perhaps this ...

13 years, 2 months ago (2011-10-04 20:37:08 UTC) #3

Committed revision 2409.

Expand All Messages | Collapse All Messages