Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1447)

Issue 51800043: FSA Fix Cobertura intrumentation to include the adaptor clone jar. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 3 months ago by Brett
Modified:
10 years, 3 months ago
Reviewers:
ejona, pjo
CC:
connector-cr_google.com
Visibility:
Public.

Description

Fix Cobertura intrumentation to include the adaptor clone jar in the classpath. Otherwise instrumentation complains that it cannot find adaptor framework classes.

Patch Set 1 #

Patch Set 2 : Use auxClassPath in cobertura-instrument, instead of creating a separate path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build.xml View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Brett
10 years, 3 months ago (2014-01-14 01:45:53 UTC) #1
ejona
Including more description as to what is going on would be helpful. However, I think ...
10 years, 3 months ago (2014-01-14 01:48:13 UTC) #2
Brett
Use auxClassPath in cobertura-instrument, instead of creating a separate path.
10 years, 3 months ago (2014-01-14 01:56:15 UTC) #3
ejona
LGTM
10 years, 3 months ago (2014-01-14 17:40:45 UTC) #4
ejona
I wondered why I didn't notice your update to this issue yesterday. It seems that ...
10 years, 3 months ago (2014-01-14 17:42:03 UTC) #5
brett.michael.johnson_gmail.com
I could be that I forgot —send_mail, which I do 20% of the time with ...
10 years, 3 months ago (2014-01-14 18:06:28 UTC) #6
ejona
Please close, since the code has been committed.
10 years, 3 months ago (2014-01-17 00:21:27 UTC) #7
Brett
10 years, 3 months ago (2014-01-17 00:25:48 UTC) #8
Committed 14 January 2014 to File System Adaptor
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b