Issue 5178045: Revert r2122, r2116, r2108 Now that Chrome's PlatformDevice doesn't inherit from SkDevice.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 5178045: Revert r2122, r2116, r2108 Now that Chrome's PlatformDevice doesn't inherit from SkDevice. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 11 months ago by Steve VanDeBogart

Modified:
12 years, 11 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Revert r2122, r2116, r2108 Now that Chrome's PlatformDevice doesn't inherit from SkDevice. Committed: http://code.google.com/p/skia/source/detail?r=2396

Patch Set 1 #

Patch Set 2 : Remove extra method #

Created: 12 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -21 lines)			Patch
M	include/core/SkDevice.h	View		2 chunks	+2 lines, -5 lines	0 comments	Download
M	include/pdf/SkPDFDevice.h	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

12 years, 11 months ago (2011-10-03 19:01:47 UTC) #2

always happy to make more functions private (or go away) :) LGTM

Expand All Messages | Collapse All Messages